[PR #15108] [MERGED] Add "legacy" themes #30431

Open
opened 2026-01-31 09:40:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15108
Author: @zadjii-msft
Created: 4/4/2023
Status: ✅ Merged
Merged: 4/6/2023
Merged by: @DHowett

Base: main ← Head: dev/migrie/b/14858-new-default-themes


📝 Commits (3)

  • 1b689ea Add "legacy" themes
  • 10b823e Merge remote-tracking branch 'origin/main' into dev/migrie/b/14858-new-default-themes
  • e49c68f runformat

📊 Changes

4 files changed (+75 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.cpp (+15 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+15 -3)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+15 -5)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+30 -0)

📄 Description

This is a minimal version of the requests for #14858. In that thread we discussed FULL reverting the default themes to the old ones. In later discussion, we decided meh, let's just ship the legacy themes too, so it's easy to go back if you should choose. The default still remains the sane dark, but the legacy* themes are all right there, and given the same special treatment as the other inbox themes.

Closes #14858
Closes #14844


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15108 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/4/2023 **Status:** ✅ Merged **Merged:** 4/6/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/14858-new-default-themes` --- ### 📝 Commits (3) - [`1b689ea`](https://github.com/microsoft/terminal/commit/1b689eaf1c3e67fce93b282b9e82df887230748b) Add "legacy" themes - [`10b823e`](https://github.com/microsoft/terminal/commit/10b823e547ffdac2534001e34740d78ee660e46a) Merge remote-tracking branch 'origin/main' into dev/migrie/b/14858-new-default-themes - [`e49c68f`](https://github.com/microsoft/terminal/commit/e49c68f94965f4c484cd243f2332ec579d006064) runformat ### 📊 Changes **4 files changed** (+75 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearanceViewModel.cpp` (+15 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+15 -3) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+15 -5) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+30 -0) </details> ### 📄 Description This is a minimal version of the requests for #14858. In that thread we discussed FULL reverting the default themes to the old ones. In later discussion, we decided _meh_, let's just ship the legacy themes too, so it's easy to go back if you should choose. The default still remains the sane `dark`, but the `legacy*` themes are all right there, and given the same special treatment as the other inbox themes. Closes #14858 Closes #14844 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30431