[PR #15164] [MERGED] Remove a 1px gap under the tabs only visible at >150% #30460

Open
opened 2026-01-31 09:40:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15164
Author: @zadjii-msft
Created: 4/11/2023
Status: Merged
Merged: 4/20/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/b/mux-2.8-tab-gap


📝 Commits (6)

  • 53149c5 Remove a 1px gap under the tabs only visible at >150%
  • 3628138 didn't need this
  • 04764ec Merge remote-tracking branch 'origin/main' into dev/migrie/b/mux-2.8-tab-gap
  • 4d47892 I do not understand XAML
  • cf08324 Merge remote-tracking branch 'origin/main' into dev/migrie/b/mux-2.8-tab-gap
  • 7e19e0a make this no worse than main

📊 Changes

3 files changed (+15 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+1 -0)
📝 src/cascadia/TerminalApp/MinMaxCloseControl.xaml (+2 -2)
📝 src/cascadia/TerminalApp/TabRowControl.xaml (+12 -1)

📄 Description

Set the padding to the default TabViewHeaderPadding (8,0,0,0), but with
-1 on the bottom. This prevents a small 1px gap that can appear on 150%
scale displays between the tab item and the content. The 1 on top helps keep
the tab the correct relative height within the tab row.

Regressed in #15078

See also MSFT:40692364


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15164 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/11/2023 **Status:** ✅ Merged **Merged:** 4/20/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/mux-2.8-tab-gap` --- ### 📝 Commits (6) - [`53149c5`](https://github.com/microsoft/terminal/commit/53149c5a931e9652cd94e57192cd6df9b7772360) Remove a 1px gap under the tabs only visible at >150% - [`3628138`](https://github.com/microsoft/terminal/commit/3628138869035c712db6376fc9aee0cd77480059) didn't need this - [`04764ec`](https://github.com/microsoft/terminal/commit/04764ec774f024906552a6af8a28ff96b0e4a049) Merge remote-tracking branch 'origin/main' into dev/migrie/b/mux-2.8-tab-gap - [`4d47892`](https://github.com/microsoft/terminal/commit/4d47892db28d58096a46769bb8229f0c879edcd8) I do not understand XAML - [`cf08324`](https://github.com/microsoft/terminal/commit/cf083242f3cbd35a0d19d9f9b12c42bc19f7dc8e) Merge remote-tracking branch 'origin/main' into dev/migrie/b/mux-2.8-tab-gap - [`7e19e0a`](https://github.com/microsoft/terminal/commit/7e19e0a6606d7df73321f597277aafef93f38f4a) make this no worse than main ### 📊 Changes **3 files changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+1 -0) 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.xaml` (+2 -2) 📝 `src/cascadia/TerminalApp/TabRowControl.xaml` (+12 -1) </details> ### 📄 Description Set the padding to the default TabViewHeaderPadding (8,0,0,0), but with -1 on the bottom. This prevents a small 1px gap that can appear on 150% scale displays between the tab item and the content. The 1 on top helps keep the tab the correct relative height within the tab row. Regressed in #15078 See also MSFT:40692364 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:40:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30460