starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15195] [MERGED] Add a warning when a proportional font is selected #30480

New Issue
Open
opened 2026-01-31 09:41:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:41:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15195
Author: @jamespack
Created: 4/17/2023
Status: ✅ Merged
Merged: 4/20/2023
Merged by: @zadjii-msft

Base: main ← Head: terminal-13389

📝 Commits (10+)

  • 0334c95 Default to XamlRoot when unable to find focused object in OnDirectKeyEvent
  • 74a7682 run code format
  • a909b0c Merge branch 'main' of https://github.com/jamespack/terminal into terminal-14397
  • 1828b13 Add warning info bar when a non monospaced font is selected
  • 07393e7 Run code format
  • f21032e Spell check
  • 9a815e0 Revert commit that snuck in. :|
  • 04c1cf5 Address feedback. Run code format and xaml styler
  • cee165d Running xstyler is a challenge. I must have something goofed on my machine.
  • fa96eb2 Think I figured out my Invoke-XamlFormat issue. Sorry for repeat commits

📊 Changes

5 files changed (+32 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+16 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+6 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+8 -0)

📄 Description

Summary of the Pull Request

Add an infobar warning when a non-monospaced font is selected.

References and Relevant Issues

#13389

Detailed Description of the Pull Request / Additional comments

I initially had the IsOpen property of the infobar bound to the ShowAllFonts checkbox property. However, I felt we could do better by adding a property for it since there was already a method defined to inspect whether the selected font was in the MonoSpaceFontList.

Validation Steps Performed

Warning shows up when a non-monospaced font is selected either globally or on individual profiles. All existing tests continue to pass.
image

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15195 **Author:** [@jamespack](https://github.com/jamespack) **Created:** 4/17/2023 **Status:** ✅ Merged **Merged:** 4/20/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `terminal-13389` --- ### 📝 Commits (10+) - [`0334c95`](https://github.com/microsoft/terminal/commit/0334c9549c67ed450712e22b8f7b373486c0cf2b) Default to XamlRoot when unable to find focused object in OnDirectKeyEvent - [`74a7682`](https://github.com/microsoft/terminal/commit/74a768270a1a4481dabadd4d171cf25af4ecda5f) run code format - [`a909b0c`](https://github.com/microsoft/terminal/commit/a909b0c09a9e508d3286960462cb8975c58f889c) Merge branch 'main' of https://github.com/jamespack/terminal into terminal-14397 - [`1828b13`](https://github.com/microsoft/terminal/commit/1828b139bc3de83e0fc251fd553f71bfd14e4a4d) Add warning info bar when a non monospaced font is selected - [`07393e7`](https://github.com/microsoft/terminal/commit/07393e776d1be7e27b8f7ccb81fccdad9371ee44) Run code format - [`f21032e`](https://github.com/microsoft/terminal/commit/f21032e7a45aadae9e92c428639361fc0db15b72) Spell check - [`9a815e0`](https://github.com/microsoft/terminal/commit/9a815e00cfc093a63e3e4291b3009324106ebfcf) Revert commit that snuck in. :| - [`04c1cf5`](https://github.com/microsoft/terminal/commit/04c1cf593b9a09f787735ea1b18dfdc09f3ddbc5) Address feedback. Run code format and xaml styler - [`cee165d`](https://github.com/microsoft/terminal/commit/cee165d92a71dc4ea2ec431776408a54fdac72fa) Running xstyler is a challenge. I must have something goofed on my machine. - [`fa96eb2`](https://github.com/microsoft/terminal/commit/fa96eb2725f1c15ceb716219a4287c1762a8b699) Think I figured out my Invoke-XamlFormat issue. Sorry for repeat commits ### 📊 Changes **5 files changed** (+32 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+16 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+6 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+8 -0) </details> ### 📄 Description ## Summary of the Pull Request Add an infobar warning when a non-monospaced font is selected. ## References and Relevant Issues #13389 ## Detailed Description of the Pull Request / Additional comments I initially had the `IsOpen` property of the infobar bound to the `ShowAllFonts` checkbox property. However, I felt we could do better by adding a property for it since there was already a method defined to inspect whether the selected font was in the `MonoSpaceFontList`. ## Validation Steps Performed Warning shows up when a non-monospaced font is selected either globally or on individual profiles. All existing tests continue to pass. <img width="868" alt="image" src="https://user-images.githubusercontent.com/2086722/232594214-cd42397b-ce9d-499c-aa73-3feaa45e850e.png"> ## PR Checklist - [x] Closes #13389 - [x] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?