[PR #15196] [MERGED] Lazy load CommandPalette and AboutDialog #30489

Open
opened 2026-01-31 09:41:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15196
Author: @lhecker
Created: 4/17/2023
Status: Merged
Merged: 4/18/2023
Merged by: @microsoft-github-policy-service[bot]

Base: dev/lhecker/fix-peasant-active-windowHead: dev/lhecker/lazy-command-palette


📝 Commits (1)

  • d11290c Lazy load CommandPalette and AboutDialog

📊 Changes

7 files changed (+78 additions, -62 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+3 -3)
📝 src/cascadia/TerminalApp/AboutDialog.cpp (+1 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+8 -7)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+13 -7)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+47 -42)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -1)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+4 -2)

📄 Description

This sets x:Load to false for the two elements.
On my system, with Windows Defender disabled, this reduces CPU
usage by 15ms and the visual delay during launch by 40ms.

Part of #5907

PR Checklist

  • Ctrl+Shift+P opens command palette
  • Context menu opens command palette
  • Context menu opens about dialog

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15196 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 4/17/2023 **Status:** ✅ Merged **Merged:** 4/18/2023 **Merged by:** [@microsoft-github-policy-service[bot]](https://github.com/apps/microsoft-github-policy-service) **Base:** `dev/lhecker/fix-peasant-active-window` ← **Head:** `dev/lhecker/lazy-command-palette` --- ### 📝 Commits (1) - [`d11290c`](https://github.com/microsoft/terminal/commit/d11290ca87af265888f8afa235d4c6f64a433ff9) Lazy load CommandPalette and AboutDialog ### 📊 Changes **7 files changed** (+78 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+3 -3) 📝 `src/cascadia/TerminalApp/AboutDialog.cpp` (+1 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+8 -7) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+13 -7) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+47 -42) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+4 -2) </details> ### 📄 Description This sets `x:Load` to `false` for the two elements. On my system, with Windows Defender disabled, this reduces CPU usage by 15ms and the visual delay during launch by 40ms. Part of #5907 ## PR Checklist * Ctrl+Shift+P opens command palette ✅ * Context menu opens command palette ✅ * Context menu opens about dialog ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30489