starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15198] [MERGED] Added Close Pane to Context Menu #30491

New Issue
Open
opened 2026-01-31 09:41:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:41:09 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15198
Author: @joadoumie
Created: 4/18/2023
Status: ✅ Merged
Merged: 4/26/2023
Merged by: @microsoft-github-policy-service[bot]

Base: main ← Head: dev/joadoumie/add_close_pane_to_context_menu

📝 Commits (4)

  • b3f78dc Added Close Pane to Context Menu
  • b5f1753 Ran code formatter
  • 722da1f Removed icon and moved leaf count pane check to _UpdateActivePane()
  • 86e3bf6 Update src/cascadia/TerminalApp/TerminalTab.cpp

📊 Changes

3 files changed (+37 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+7 -4)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+28 -0)
📝 src/cascadia/TerminalApp/TerminalTab.h (+2 -0)

📄 Description

Summary of the Pull Request

Adding a 'Close Pane' menu item in the context menu.

References and Relevant Issues

#13580

Detailed Description of the Pull Request / Additional comments

If a user decides to split a tab to create multiple panes through the context menu, they should be able to then close the pane via the context menu too. This PR introduces a new context menu item, 'Close Pane', that only appears when a user has 2 or more panes in a tab. When a user clicks close pane, the _active_pane will be closed.

Validation Steps Performed

close_pane_terminal

As it's my first PR, I still need to understand how to go through the testing suite.

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15198 **Author:** [@joadoumie](https://github.com/joadoumie) **Created:** 4/18/2023 **Status:** ✅ Merged **Merged:** 4/26/2023 **Merged by:** [@microsoft-github-policy-service[bot]](https://github.com/apps/microsoft-github-policy-service) **Base:** `main` ← **Head:** `dev/joadoumie/add_close_pane_to_context_menu` --- ### 📝 Commits (4) - [`b3f78dc`](https://github.com/microsoft/terminal/commit/b3f78dc8daefe76d8b7d3990db53e2b446735b2f) Added Close Pane to Context Menu - [`b5f1753`](https://github.com/microsoft/terminal/commit/b5f1753b8f887dad24bbcced9ea7e0e665f482fd) Ran code formatter - [`722da1f`](https://github.com/microsoft/terminal/commit/722da1f3306d9e879f8f20c08244d7ca27a33576) Removed icon and moved leaf count pane check to _UpdateActivePane() - [`86e3bf6`](https://github.com/microsoft/terminal/commit/86e3bf6237753f88b17050271909f11cbdd469e1) Update src/cascadia/TerminalApp/TerminalTab.cpp ### 📊 Changes **3 files changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+7 -4) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+28 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+2 -0) </details> ### 📄 Description ## Summary of the Pull Request Adding a 'Close Pane' menu item in the context menu. ## References and Relevant Issues #13580 ## Detailed Description of the Pull Request / Additional comments If a user decides to split a tab to create multiple panes through the context menu, they should be able to then close the pane via the context menu too. This PR introduces a new context menu item, 'Close Pane', that only appears when a user has 2 or more panes in a tab. When a user clicks close pane, the _active_pane will be closed. ## Validation Steps Performed ![close_pane_terminal](https://user-images.githubusercontent.com/98557455/232649000-8b521070-4f1b-4da9-8092-6ff802e91e2c.gif) As it's my first PR, I still need to understand how to go through the testing suite. ## PR Checklist - [x] Closes #13580 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30491
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?