[PR #15213] [MERGED] A hypothetical fix for hidden windows #30499

Open
opened 2026-01-31 09:41:13 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15213
Author: @zadjii-msft
Created: 4/20/2023
Status: Merged
Merged: 4/25/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/b/theoretical-treit-fix


📝 Commits (1)

  • fc38402 A hypothetical fix for hidden windows

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/WindowEmperor.cpp (+1 -1)

📄 Description

We had a report in a mail thread that someone's Terminal windows were getting created hidden, and never showing themselves.

As a theory, I'm guessing that dwFlags didn't say that we should actually use wShowWindow. So, to be more correct, let's actually obey that.

I'm gonna send this package to them to see if it fixes them.

Related to #14957.

Likely regressed in #13838.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15213 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/20/2023 **Status:** ✅ Merged **Merged:** 4/25/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/b/theoretical-treit-fix` --- ### 📝 Commits (1) - [`fc38402`](https://github.com/microsoft/terminal/commit/fc38402caa45dced6f3e3af6e203c17abe7ced8c) A hypothetical fix for hidden windows ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/WindowEmperor.cpp` (+1 -1) </details> ### 📄 Description We had a report in a mail thread that someone's Terminal windows were getting created hidden, and never showing themselves. As a theory, I'm guessing that dwFlags didn't say that we should actually use `wShowWindow`. So, to be more correct, let's actually obey that. I'm gonna send this package to them to see if it fixes them. Related to #14957. Likely regressed in #13838. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:13 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30499