[PR #15232] A very sensible Pane refactoring #30527

Open
opened 2026-01-31 09:41:22 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/15232

State: closed
Merged: Yes


It seemed dangerous to just have places all over Pane where we manipulate the whole cadre of TermControl events. Seemed ripe for a copypasta error. This moves that around, so there's only two methods for messing with the TermControl callbacks: _setupControlEvents and _removeControlEvents.

Closes: nothing. This was an off-the-cuff commit that seemed valuable.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/15232 **State:** closed **Merged:** Yes --- It seemed dangerous to just have places all over Pane where we manipulate the whole cadre of TermControl events. Seemed ripe for a copypasta error. This moves that around, so there's only two methods for messing with the TermControl callbacks: `_setupControlEvents` and `_removeControlEvents`. Closes: nothing. This was an off-the-cuff commit that seemed valuable.
claunia added the pull-request label 2026-01-31 09:41:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30527