[PR #15251] [MERGED] Another theoretical fix for another race condition #30540

Open
opened 2026-01-31 09:41:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15251
Author: @zadjii-msft
Created: 4/27/2023
Status: Merged
Merged: 5/1/2023
Merged by: @microsoft-github-policy-service[bot]

Base: mainHead: dev/migrie/b/15209-race


📝 Commits (1)

  • d9331be Another theoretical fix for another race condition

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.cpp (+0 -1)
📝 src/cascadia/TerminalApp/TerminalWindow.cpp (+2 -0)

📄 Description

Basically, just make sure that we register our SettingsChanged handler in TerminalWindow after TerminalWindow is actually ready to handle it. duh.

Closes #15209


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15251 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/27/2023 **Status:** ✅ Merged **Merged:** 5/1/2023 **Merged by:** [@microsoft-github-policy-service[bot]](https://github.com/apps/microsoft-github-policy-service) **Base:** `main` ← **Head:** `dev/migrie/b/15209-race` --- ### 📝 Commits (1) - [`d9331be`](https://github.com/microsoft/terminal/commit/d9331be5dac6410cecca07653ac23b8c497f53f2) Another theoretical fix for another race condition ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+0 -1) 📝 `src/cascadia/TerminalApp/TerminalWindow.cpp` (+2 -0) </details> ### 📄 Description Basically, just make sure that we register our `SettingsChanged` handler in `TerminalWindow` _after_ `TerminalWindow` is actually ready to handle it. _duh_. Closes #15209 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30540