starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15261] [MERGED] Add support for LNM (Line Feed/New Line Mode) #30551

New Issue
Open
opened 2026-01-31 09:41:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:41:31 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15261
Author: @j4james
Created: 4/28/2023
Status: ✅ Merged
Merged: 5/13/2023
Merged by: @DHowett

Base: main ← Head: feature-lnm

📝 Commits (3)

📊 Changes

12 files changed (+168 additions, -125 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+4 -6)
📝 src/cascadia/TerminalCore/TerminalApi.cpp (+4 -21)
📝 src/host/outputStream.cpp (+32 -46)
📝 src/host/outputStream.hpp (+2 -6)
📝 src/host/ut_host/ScreenBufferTests.cpp (+23 -0)
📝 src/terminal/adapter/DispatchTypes.hpp (+1 -0)
📝 src/terminal/adapter/ITerminalApi.hpp (+9 -5)
📝 src/terminal/adapter/adaptDispatch.cpp (+34 -8)
📝 src/terminal/adapter/ut_adapter/adapterTest.cpp (+48 -32)
📝 src/terminal/input/terminalInput.cpp (+9 -0)
📝 src/terminal/input/terminalInput.hpp (+1 -0)

📄 Description

This PR adds support for the ANSI Line Feed/New Line mode (LNM), which
determines whether outputting a linefeed control should also trigger a
carriage return, and whether the Return key should generate an LF in
addition to CR.

Detailed Description of the Pull Request / Additional comments

In ConHost, there was already a console mode which handled the output
side of things, but I've now also added a TerminalInput mode that
controls the behavior of the Return key. When LNM is set, both the
output and input modes are enabled, and when reset, they're disabled.

If they're not already matching, then LNM has no effect, and will be
reported as unknown when queried. This is the typical state for legacy
console applications, which expect a linefeed to trigger a carriage
return, but wouldn't want the Return key generating both CR+LF.

As part of this PR, I've also refactored the ITerminalApi interface to
consolidate what I'm now calling the "system" modes: bracketed paste,
auto wrap, and the new line feed mode. This closes another gap between
Terminal and ConHost, so both auto wrap, and line feed mode will now be
supported for conpty pass through.

Validation Steps Performed

I've added an LNM test that checks the escape sequence is triggering
both of the expected mode changes, and added an additional DECRQM test
covering the currently implemented standard modes: the new LNM, and
the existing IRM (which wasn't previously tested). I've also extended
the DECRQM private mode test to cover DECAWM and Bracketed Paste
(which we also weren't previously testing).

I've manually tested LNM in Vttest to confirm the keyboard is working
as expected.

Closes #15167

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15261 **Author:** [@j4james](https://github.com/j4james) **Created:** 4/28/2023 **Status:** ✅ Merged **Merged:** 5/13/2023 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `feature-lnm` --- ### 📝 Commits (3) - [`dc77355`](https://github.com/microsoft/terminal/commit/dc773550fbed7b085520e7538d7df4559be911db) Consolidate the "system" modes. - [`6ad0992`](https://github.com/microsoft/terminal/commit/6ad0992c3672c6a980479adb6399b2dcb40f1621) Add support for LNM. - [`d42716a`](https://github.com/microsoft/terminal/commit/d42716a9e6e4991f9dec6657bc75a27cc0db63d8) Add some unit tests. ### 📊 Changes **12 files changed** (+168 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+4 -6) 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+4 -21) 📝 `src/host/outputStream.cpp` (+32 -46) 📝 `src/host/outputStream.hpp` (+2 -6) 📝 `src/host/ut_host/ScreenBufferTests.cpp` (+23 -0) 📝 `src/terminal/adapter/DispatchTypes.hpp` (+1 -0) 📝 `src/terminal/adapter/ITerminalApi.hpp` (+9 -5) 📝 `src/terminal/adapter/adaptDispatch.cpp` (+34 -8) 📝 `src/terminal/adapter/ut_adapter/adapterTest.cpp` (+48 -32) 📝 `src/terminal/input/terminalInput.cpp` (+9 -0) 📝 `src/terminal/input/terminalInput.hpp` (+1 -0) </details> ### 📄 Description This PR adds support for the ANSI Line Feed/New Line mode (`LNM`), which determines whether outputting a linefeed control should also trigger a carriage return, and whether the `Return` key should generate an `LF` in addition to `CR`. ## Detailed Description of the Pull Request / Additional comments In ConHost, there was already a console mode which handled the output side of things, but I've now also added a `TerminalInput` mode that controls the behavior of the `Return` key. When `LNM` is set, both the output and input modes are enabled, and when reset, they're disabled. If they're not already matching, then `LNM` has no effect, and will be reported as unknown when queried. This is the typical state for legacy console applications, which expect a linefeed to trigger a carriage return, but wouldn't want the `Return` key generating both `CR`+`LF`. As part of this PR, I've also refactored the `ITerminalApi` interface to consolidate what I'm now calling the "system" modes: bracketed paste, auto wrap, and the new line feed mode. This closes another gap between Terminal and ConHost, so both auto wrap, and line feed mode will now be supported for conpty pass through. ## Validation Steps Performed I've added an `LNM` test that checks the escape sequence is triggering both of the expected mode changes, and added an additional `DECRQM` test covering the currently implemented standard modes: the new `LNM`, and the existing `IRM` (which wasn't previously tested). I've also extended the `DECRQM` private mode test to cover `DECAWM` and Bracketed Paste (which we also weren't previously testing). I've manually tested `LNM` in Vttest to confirm the keyboard is working as expected. Closes #15167 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?