starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15269] Preserve active attributes during VT resize operations #30567

New Issue
Open
opened 2026-01-31 09:41:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:41:35 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/15269

State: closed
Merged: Yes

Summary of the Pull Request

When the screen is resized in ConHost via a VT escape sequence, the
active text attributes could end up being corrupted if they were set to
something that the legacy console APIs didn't support (e.g. RGB colors).
This PR fixes that issue.

Detailed Description of the Pull Request / Additional comments

The way a resize is implemented is by retrieving the buffer information
with GetConsoleScreenBufferInfoEx, updating the size fields, and then
writing the data back out again with SetConsoleScreenBufferInfoEx.
However, this also results in the active attributes being updated via
the wAttributes field, and that's only capable of representing legacy
console attributes.

We address this by saving the full TextAttribute value before it gets
corrupted in the SetConsoleScreenBufferInfoEx call, and then restore
it again afterwards.

Validation Steps Performed

I've added a unit test to verify the attributes are correctly preserved
for all VT resize operations, and I've also manually confirmed the test
case in #2540 is now working as expected.

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/15269 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request When the screen is resized in ConHost via a VT escape sequence, the active text attributes could end up being corrupted if they were set to something that the legacy console APIs didn't support (e.g. RGB colors). This PR fixes that issue. ## Detailed Description of the Pull Request / Additional comments The way a resize is implemented is by retrieving the buffer information with `GetConsoleScreenBufferInfoEx`, updating the size fields, and then writing the data back out again with `SetConsoleScreenBufferInfoEx`. However, this also results in the active attributes being updated via the `wAttributes` field, and that's only capable of representing legacy console attributes. We address this by saving the full `TextAttribute` value before it gets corrupted in the `SetConsoleScreenBufferInfoEx` call, and then restore it again afterwards. ## Validation Steps Performed I've added a unit test to verify the attributes are correctly preserved for all VT resize operations, and I've also manually confirmed the test case in #2540 is now working as expected. ## PR Checklist - [x] Closes #2540 - [x] Tests added/passed - [ ] Documentation updated - [ ] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:41:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30567
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?