[PR #15282] [MERGED] Add an action to display toast with the CWD of the Terminal #30569

Closed
opened 2026-01-31 09:41:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15282
Author: @zadjii-msft
Created: 5/3/2023
Status: Merged
Merged: 7/20/2023
Merged by: @zadjii-msft

Base: mainHead: dev/migrie/f/show-cwd


📝 Commits (10+)

  • 816f8b2 dirty: stash a string as a "virtual" CWD, ala #5506
  • 03e6044 cleanup for review
  • 553f48d a toast for showing the CWD of the Terminal. This is for debugging
  • c83f174 cleanup for review
  • 5c377d8 cleanup from review
  • eb97e9f Merge remote-tracking branch 'origin/main' into dev/migrie/b/5506-virtual-cwd
  • c01611d start writing tests
  • 51a8df7 huzzah tests pass
  • 8c797f8 OKAY it works now
  • ddce6eb Merge branch 'dev/migrie/b/5506-virtual-cwd' into dev/migrie/f/show-cwd

📊 Changes

7 files changed (+51 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+10 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+27 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+6 -0)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+3 -0)

📄 Description

Adds an action to display a toast containing the Terminal's "virtual" CWD.

As described in https://github.com/microsoft/terminal/issues/4637#issuecomment-1531979200.

Useful for debugging #5506 et. al. I almost left it as a debug-only feature, but figured it would be helpful for others in the #4637 landscape of things.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15282 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/3/2023 **Status:** ✅ Merged **Merged:** 7/20/2023 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `main` ← **Head:** `dev/migrie/f/show-cwd` --- ### 📝 Commits (10+) - [`816f8b2`](https://github.com/microsoft/terminal/commit/816f8b2026368a4af12476d4c7de946acb238a7e) dirty: stash a string as a "virtual" CWD, ala #5506 - [`03e6044`](https://github.com/microsoft/terminal/commit/03e60443e5dc8c1ac4ab34ee44552ff8cc278c57) cleanup for review - [`553f48d`](https://github.com/microsoft/terminal/commit/553f48d38efc7c82f1b58fb7d50dc7ae1006f14d) a toast for showing the CWD of the Terminal. This is for debugging - [`c83f174`](https://github.com/microsoft/terminal/commit/c83f1747d6197fdbb2ca6f88778bf71d6c84c54c) cleanup for review - [`5c377d8`](https://github.com/microsoft/terminal/commit/5c377d82cdaaa4f0e2c90808cdfb65597331c9e0) cleanup from review - [`eb97e9f`](https://github.com/microsoft/terminal/commit/eb97e9f76a0369d070995276a18b53b9249e8e9c) Merge remote-tracking branch 'origin/main' into dev/migrie/b/5506-virtual-cwd - [`c01611d`](https://github.com/microsoft/terminal/commit/c01611d5556c18dfeaf7c94176d61ac1f4c91f3b) start writing tests - [`51a8df7`](https://github.com/microsoft/terminal/commit/51a8df706d2a8772d52b60a5ca6987ca8a3b6779) huzzah tests pass - [`8c797f8`](https://github.com/microsoft/terminal/commit/8c797f8a6d335e18afb1067f788888e133f890ab) OKAY it works now - [`ddce6eb`](https://github.com/microsoft/terminal/commit/ddce6eb1fb288fe81011bd18dd320cf98ed42e04) Merge branch 'dev/migrie/b/5506-virtual-cwd' into dev/migrie/f/show-cwd ### 📊 Changes **7 files changed** (+51 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+10 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+27 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+6 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+3 -0) </details> ### 📄 Description Adds an action to display a toast containing the Terminal's "virtual" CWD. As described in https://github.com/microsoft/terminal/issues/4637#issuecomment-1531979200. Useful for debugging #5506 et. al. I almost left it as a debug-only feature, but figured it would be helpful for others in the #4637 landscape of things. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:36 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30569