[PR #15286] [MERGED] Manually pre-evaluate the starting directory when calling elevate-shim #30570

Open
opened 2026-01-31 09:41:37 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15286
Author: @zadjii-msft
Created: 5/4/2023
Status: Merged
Merged: 5/15/2023
Merged by: @microsoft-github-policy-service[bot]

Base: mainHead: dev/migrie/b/15173-ctrl-click-same-cwd


📝 Commits (10+)

  • 816f8b2 dirty: stash a string as a "virtual" CWD, ala #5506
  • 03e6044 cleanup for review
  • e1c0bb7 This works for #15173, but no me gusta
  • 230be3e okay this actually works now
  • 5c377d8 cleanup from review
  • eb97e9f Merge remote-tracking branch 'origin/main' into dev/migrie/b/5506-virtual-cwd
  • c01611d start writing tests
  • 51a8df7 huzzah tests pass
  • 8c797f8 OKAY it works now
  • d75323f Merge branch 'dev/migrie/b/5506-virtual-cwd' into dev/migrie/b/15173-ctrl-click-same-cwd

📊 Changes

2 files changed (+13 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+10 -7)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -0)

📄 Description

targets #15280

When ctrl+clicking on a profile, pre-evaluate the starting directory of that profile, and stash that in the commandline we pass to elevate shim.

So in the case of something like "use parent process directory", we'll run elevate-shim new-tab -p {guid} -d "C:\\the path\\of\\terminal\\."

Closes #15173


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15286 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/4/2023 **Status:** ✅ Merged **Merged:** 5/15/2023 **Merged by:** [@microsoft-github-policy-service[bot]](https://github.com/apps/microsoft-github-policy-service) **Base:** `main` ← **Head:** `dev/migrie/b/15173-ctrl-click-same-cwd` --- ### 📝 Commits (10+) - [`816f8b2`](https://github.com/microsoft/terminal/commit/816f8b2026368a4af12476d4c7de946acb238a7e) dirty: stash a string as a "virtual" CWD, ala #5506 - [`03e6044`](https://github.com/microsoft/terminal/commit/03e60443e5dc8c1ac4ab34ee44552ff8cc278c57) cleanup for review - [`e1c0bb7`](https://github.com/microsoft/terminal/commit/e1c0bb7277533eb8b9c797de4c02bc9335364a60) This works for #15173, but no me gusta - [`230be3e`](https://github.com/microsoft/terminal/commit/230be3e45640ec81f208e9186b4e6ff8f8afdf38) okay this actually works now - [`5c377d8`](https://github.com/microsoft/terminal/commit/5c377d82cdaaa4f0e2c90808cdfb65597331c9e0) cleanup from review - [`eb97e9f`](https://github.com/microsoft/terminal/commit/eb97e9f76a0369d070995276a18b53b9249e8e9c) Merge remote-tracking branch 'origin/main' into dev/migrie/b/5506-virtual-cwd - [`c01611d`](https://github.com/microsoft/terminal/commit/c01611d5556c18dfeaf7c94176d61ac1f4c91f3b) start writing tests - [`51a8df7`](https://github.com/microsoft/terminal/commit/51a8df706d2a8772d52b60a5ca6987ca8a3b6779) huzzah tests pass - [`8c797f8`](https://github.com/microsoft/terminal/commit/8c797f8a6d335e18afb1067f788888e133f890ab) OKAY it works now - [`d75323f`](https://github.com/microsoft/terminal/commit/d75323f1495752db5c2cabee7585e8e6e4f7500a) Merge branch 'dev/migrie/b/5506-virtual-cwd' into dev/migrie/b/15173-ctrl-click-same-cwd ### 📊 Changes **2 files changed** (+13 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+10 -7) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -0) </details> ### 📄 Description _targets #15280_ When ctrl+clicking on a profile, pre-evaluate the starting directory of that profile, and stash that in the commandline we pass to elevate shim. So in the case of something like "use parent process directory", we'll run `elevate-shim new-tab -p {guid} -d "C:\\the path\\of\\terminal\\."` Closes #15173 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30570