[PR #15329] [MERGED] Move TSM's u8 reader/writer into til::io #30589

Open
opened 2026-01-31 09:41:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/15329
Author: @DHowett
Created: 5/10/2023
Status: Merged
Merged: 7/17/2024
Merged by: @DHowett

Base: mainHead: dev/duhowett/til_fileio


📝 Commits (5)

  • d7b2b17 Move TSM's u8 reader/writer into til::io
  • fa6720e okay make sure it compiles too
  • 2d9fa8b Annoyingly, all of these had optional args
  • 8f991b0 Merge remote-tracking branch 'origin/main' into dev/duhowett/til_fileio
  • a5bbd65 .c_str() considered harmful

📊 Changes

9 files changed (+288 additions, -284 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabManagement.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.cpp (+9 -7)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+0 -9)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+0 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.idl (+0 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+6 -4)
📝 src/cascadia/TerminalSettingsModel/FileUtils.cpp (+0 -256)
📝 src/cascadia/TerminalSettingsModel/FileUtils.h (+0 -4)
src/inc/til/io.h (+271 -0)

📄 Description

This allows us to remove ExportFile (?) from the API surface of CascadiaSettings (???).

It will probably result in a small code size increase, but maybe we'll save that by making the .winmd smaller. :P


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/15329 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 5/10/2023 **Status:** ✅ Merged **Merged:** 7/17/2024 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/til_fileio` --- ### 📝 Commits (5) - [`d7b2b17`](https://github.com/microsoft/terminal/commit/d7b2b1798c944ab9e3700772ba4a6df93eb68a7f) Move TSM's u8 reader/writer into til::io - [`fa6720e`](https://github.com/microsoft/terminal/commit/fa6720e4fdf9ea99ec49322c4c88b98df78e8b64) okay make sure it compiles too - [`2d9fa8b`](https://github.com/microsoft/terminal/commit/2d9fa8b915b48ff939343f534f0f048431d192bc) Annoyingly, all of these had optional args - [`8f991b0`](https://github.com/microsoft/terminal/commit/8f991b0e8b7f53cb97901803dfc5e642b165e3ba) Merge remote-tracking branch 'origin/main' into dev/duhowett/til_fileio - [`a5bbd65`](https://github.com/microsoft/terminal/commit/a5bbd65abe77eee0082874789f3181a3e5977f0d) .c_str() considered harmful ### 📊 Changes **9 files changed** (+288 additions, -284 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.cpp` (+9 -7) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+0 -9) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.idl` (+0 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+6 -4) 📝 `src/cascadia/TerminalSettingsModel/FileUtils.cpp` (+0 -256) 📝 `src/cascadia/TerminalSettingsModel/FileUtils.h` (+0 -4) ➕ `src/inc/til/io.h` (+271 -0) </details> ### 📄 Description This allows us to remove ExportFile (?) from the API surface of CascadiaSettings (???). It will probably result in a small code size increase, but maybe we'll save that by making the .winmd smaller. :P --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:41:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30589