starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15328] (WIP) Improve pointer safety around coroutines #30592

New Issue
Open
opened 2026-01-31 09:41:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:41:45 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/15328

State: closed
Merged: No

I went through random parts of Windows Terminal trying to fix as many
theoretical (and practical) bugs I could find. My initial idea was that
one of the biggest sources of easily detectable bugs are coroutines
which do not properly hold onto their this pointer strongly across
suspension points. This commit fixes maybe about 3/4ths of those bugs.
Other bugs, like nullptr crashes, are significantly harder to spot.

To do so I've removed resume_foreground/background from as many
coroutines as I could and then added assertions that data only got
accessed on the UI threads. This allowed me to remove most coroutines.
Next, I've added get_weak/strong() pointers to the remaining ones.

As a drive by it also improves the following:

  • QuitAllRequestedArgs technically isn't needed, because there was no
    reason for _saveWindowLayouts() to yield to a background thread in
    the first place.

Validation Steps Performed

  • TBA (I'll go through all changes and assemble a list of functionalities these affect)
**Original Pull Request:** https://github.com/microsoft/terminal/pull/15328 **State:** closed **Merged:** No --- I went through random parts of Windows Terminal trying to fix as many theoretical (and practical) bugs I could find. My initial idea was that one of the biggest sources of easily detectable bugs are coroutines which do not properly hold onto their `this` pointer strongly across suspension points. This commit fixes maybe about 3/4ths of those bugs. Other bugs, like `nullptr` crashes, are significantly harder to spot. To do so I've removed `resume_foreground/background` from as many coroutines as I could and then added assertions that data only got accessed on the UI threads. This allowed me to remove most coroutines. Next, I've added `get_weak/strong()` pointers to the remaining ones. As a drive by it also improves the following: * `QuitAllRequestedArgs` technically isn't needed, because there was no reason for `_saveWindowLayouts()` to yield to a background thread in the first place. ## Validation Steps Performed * TBA (I'll go through all changes and assemble a list of functionalities these affect)
claunia added the pull-request label 2026-01-31 09:41:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?