[PR #15337] Fix WindowEmperor exiting too early #30602

Open
opened 2026-01-31 09:41:48 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/15337

State: closed
Merged: Yes


WindowEmperor would exit as soon as the last window would enter
RundownForExit(), which is too early and triggers leak checks.
This commit splits up the shutdown up into deregistering the window from
the list of windows and into actually decrementing the window count.

Closes #15306

Validation Steps Performed

  • D2D leak warnings seem to disappear ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/15337 **State:** closed **Merged:** Yes --- `WindowEmperor` would exit as soon as the last window would enter `RundownForExit()`, which is too early and triggers leak checks. This commit splits up the shutdown up into deregistering the window from the list of windows and into actually decrementing the window count. Closes #15306 ## Validation Steps Performed * D2D leak warnings seem to disappear ✅
claunia added the pull-request label 2026-01-31 09:41:48 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30602