[PR #15566] Remove boolean success return values from TextBuffer #30674

Open
opened 2026-01-31 09:42:14 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/15566

State: closed
Merged: Yes


I've removed these because it made some of my new code pretty
convoluted for now good reason as most of these functions aren't
exception safe to begin with. Basically, their boolean status
is often just a pretense because they can crash or throw anyways.

Furthermore, WriteCharsLegacy failed to check the status code
returned by AdjustCursorPosition in some of its parts too.

In the future we should instead probably strive to continue
make our legacy code more exception safe.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/15566 **State:** closed **Merged:** Yes --- I've removed these because it made some of my new code pretty convoluted for now good reason as most of these functions aren't exception safe to begin with. Basically, their boolean status is often just a pretense because they can crash or throw anyways. Furthermore, `WriteCharsLegacy` failed to check the status code returned by `AdjustCursorPosition` in some of its parts too. In the future we should instead probably strive to continue make our legacy code more exception safe.
claunia added the pull-request label 2026-01-31 09:42:14 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30674