[PR #15780] Merge ReadConsoleA/W API routines #30730

Open
opened 2026-01-31 09:42:38 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/15780

State: closed
Merged: Yes


This is a minor cleanup to deduplicate the two ReadConsole methods
and will help with making changes to how COOKED_READ_DATA is called.
It additionally changes the initial data payload from a string_view
to a wstring_view as it is guaranteed to be wchar_t.
This matches the current COOKED_READ_DATA implementation which
blindly assumes that the initial data consists of wchar_t.

Closes #5618

**Original Pull Request:** https://github.com/microsoft/terminal/pull/15780 **State:** closed **Merged:** Yes --- This is a minor cleanup to deduplicate the two ReadConsole methods and will help with making changes to how `COOKED_READ_DATA` is called. It additionally changes the initial data payload from a `string_view` to a `wstring_view` as it is guaranteed to be `wchar_t`. This matches the current `COOKED_READ_DATA` implementation which blindly assumes that the initial data consists of `wchar_t`. Closes #5618
claunia added the pull-request label 2026-01-31 09:42:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30730