starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #15795] Add support for underline style and color in VT #30736

New Issue
Open
opened 2026-01-31 09:42:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:42:40 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/15795

State: closed
Merged: Yes

Add support for underline style and color in VT.

Underline color sequence SGR 58 (unlike SGR 38, SGR 48) only works with sub parameters, eg. \e[58:5:<n>m or \e[58:2::<r>:<g>:<b>m will work, but something like \e[58;5;<n>m won't work. This is a requirement for the implementation to avoid problems with VT clients that don't support sub parameters.

Detailed Description

  • Added underlineColor to TextAttribute, and UnderlineStyle into CharacterAttributes.
  • Added two new entries in GraphicOptions namely, UnderlineColor (58) and UnderlineColorDefault (59).
  • SGR 58 renders a sequence with sub parameters in the VT renderer.
  • SGR 4:x renders a sequence with sub parameters in the VT renderer, except for single, double, and no-underline, which still use backward-compatible SGR 4, SGR 21 and SGR 24.
  • XtermEngine will send \e[4m without any styling information. This means all underline style (except NoUnderline) will be rendered as single underline.

Reference issues

PR Checklist

  • Use pre-calculated maps for efficient mapping between CharacterAttributes and UnderlineStyle. (Not required)
  • update DECRARA, DECCARA to respect underline color and style.
  • update DECRQSS to send underline color and style in the query response.
  • update DECRQPSR/DECRSPS/DECCIR
  • Tests added
**Original Pull Request:** https://github.com/microsoft/terminal/pull/15795 **State:** closed **Merged:** Yes --- Add support for underline style and color in VT. Underline color sequence _SGR 58_ (unlike *SGR 38*, *SGR 48*) only works with sub parameters, eg. `\e[58:5:<n>m` or `\e[58:2::<r>:<g>:<b>m` will work, but something like `\e[58;5;<n>m` won't work. This is a requirement for the implementation to avoid problems with VT clients that don't support sub parameters. ## Detailed Description - Added `underlineColor` to `TextAttribute`, and `UnderlineStyle` into `CharacterAttributes`. - Added two new entries in `GraphicOptions` namely, `UnderlineColor` (58) and `UnderlineColorDefault` (59). - _SGR 58_ renders a sequence with sub parameters in the VT renderer. - _SGR 4:x_ renders a sequence with sub parameters in the VT renderer, except for single, double, and no-underline, which still use backward-compatible _SGR 4_, _SGR 21_ and _SGR 24_. - `XtermEngine` will send `\e[4m` without any styling information. This means all underline style (except NoUnderline) will be rendered as single underline. ## Reference issues - #7228 ### PR Checklist - [x] ~Use pre-calculated maps for efficient mapping between `CharacterAttributes` and `UnderlineStyle`.~ (Not required) - [x] update DECRARA, DECCARA to respect underline color and style. - [x] update DECRQSS to send underline color and style in the query response. - [x] update DECRQPSR/DECRSPS/DECCIR - [x] Tests added
claunia added the pull-request label 2026-01-31 09:42:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?