[PR #16004] Don't update the settings, unless the theme actually changed #30802

Open
opened 2026-01-31 09:43:05 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/16004

State: closed
Merged: Yes


ImmersiveColorSet gets sent more often than just on a theme change. It notably gets sent when the PC is locked, or the UAC prompt opens.

Validation Steps Performed

Tested manually by setting the font to garboand:

  • locking, then logging back in. No dialog ✅
  • UAC via run dialog + regedit. No dialog ✅
  • Actually changing the OS theme. Dialog ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/16004 **State:** closed **Merged:** Yes --- `ImmersiveColorSet` gets sent more often than just on a theme change. It notably gets sent when the PC is locked, or the UAC prompt opens. ## Validation Steps Performed Tested manually by setting the font to `garbo`and: * locking, then logging back in. No dialog ✅ * UAC via run dialog + `regedit`. No dialog ✅ * Actually changing the OS theme. Dialog ✅ - [x] Closes #15732
claunia added the pull-request label 2026-01-31 09:43:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30802