starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #16047] Theoretical fix for some crashes #30812

New Issue
Open
opened 2026-01-31 09:43:09 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:43:09 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/16047

State: closed
Merged: Yes

Found this while looking through dumps for failure f544cf8e-1879-c59b-3f0b-1a364b92b974. That's MSFT:45210947. (1% of our 1.19 crashes)

From the dump I looked at,

Looks like,

  • we're on Windows 10
  • We're refrigerating a window
  • We are pumping the remaining XAML messages as we refrigerate (_pumpRemainingXamlMessages)
  • In there, we're finally getting the TerminalPage::_CompleteInitialization
  • that calls up to the _root->Initialized lambda set up in TerminalWindow::Initialize
  • There it tries to get the launch mode from the settings, and explodes. Presumably _settings is null, but can't see in this dump.

so the window is closing before it's initialized.

When we _warmWindow = std::move(_host->Refrigerate()), we call AppHost::Refrigerate, which will null out the TerminalWindow. So when we're getting to TerminalWindow::Initialize, we're calling that on a nullptr. That's the trick.

We need to revoke the internal Initialized callback. Which makes sense. It's a lambda that binds this 🤦

After more looking, it really doesn't seem like the stacks that are tracked in f544cf8e-1879-c59b-3f0b-1a364b92b974 look like the same stack that I was debugging, but this is a realy issue regardless.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/16047 **State:** closed **Merged:** Yes --- Found this while looking through dumps for failure `f544cf8e-1879-c59b-3f0b-1a364b92b974`. That's MSFT:45210947. (1% of our 1.19 crashes) From the dump I looked at, Looks like, * we're on Windows 10 * We're refrigerating a window * We are pumping the remaining XAML messages as we refrigerate (`_pumpRemainingXamlMessages`) * In there, we're finally getting the `TerminalPage::_CompleteInitialization` * that calls up to the `_root->Initialized` lambda set up in `TerminalWindow::Initialize` * There it tries to get the launch mode from the settings, and explodes. Presumably _settings is null, but can't see in this dump. so the window is closing before it's initialized. When we `_warmWindow = std::move(_host->Refrigerate())`, we call `AppHost::Refrigerate`, which will null out the TerminalWindow. So when we're getting to `TerminalWindow::Initialize`, we're calling that on a nullptr. That's the trick. We need to revoke the internal Initialized callback. Which makes sense. It's a lambda that binds _this_ 🤦 --- After more looking, it really doesn't _seem_ like the stacks that are tracked in `f544cf8e-1879-c59b-3f0b-1a364b92b974` look like the same stack that I was debugging, but this _is_ a realy issue regardless.
claunia added the pull-request label 2026-01-31 09:43:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?