starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #16127] Check spelling 0.0.22 #30845

New Issue
Open
opened 2026-01-31 09:43:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:43:19 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/16127

State: closed
Merged: Yes

Summary of the Pull Request

Upgrades check-spelling to v0.0.22

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

  • refreshes workflow
    • enables dependabot PRs to trigger CI (so that in the future you'll be able to see breaking changes to the dictionary paths)
  • refreshes metadata
  • built-in handling of \n/\r/\t is removed -- This means that the patterns/0_*.txt files can be removed.
  • this specific PR includes some shim content, in allow/check-spelling-0.0.21.txt -- once it this PR merges, it can be removed on a branch and the next CI will clean out items from expect.txt relating to the \r stuff and suggest replacement content.
  • talking to the bot is enabled for forks (but not the master repository)
  • SARIF reporting is enabled for PRs w/in a single repository (not across forks)
  • In job reports, there's a summary table (space permitting) linking to instances (this is a poor man's SARIF report)
  • When a pattern splits a thing that results in check-spelling finding an unrecognized token, that's reported with a distinct category
  • When there are items in expect that not longer match anything but more specific items do (e.g. microsoft vs. Microsoft), there's now a specific category with help/advice
  • Fancier excludes suggestions (excluding directories, file types, ...)
  • Refreshed dictionaries
  • The comment now links to the job summary (which includes SARIF link if available, the details view, and a generated commit that people can use if they're ok w/ the expect changes and don't want to run perl)

Validation Steps Performed

  1. the branch was developed in https://github.com/check-spelling-sandbox/terminal/actions?query=branch%3Acheck-spelling-0.0.22
  2. ensuring compatibility with 0.0.21 was done in https://github.com/check-spelling-sandbox/terminal/pull/3
  3. this version has been in development for a year and has quite a few improvements, we've been actively dogfooding it throughout this period 😄

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)
**Original Pull Request:** https://github.com/microsoft/terminal/pull/16127 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Upgrades [check-spelling to v0.0.22](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.22) ## References and Relevant Issues ## Detailed Description of the Pull Request / Additional comments * refreshes workflow * enables dependabot PRs to trigger CI (so that in the future you'll be able to see breaking changes to the dictionary paths) * refreshes metadata * built-in handling of `\n`/`\r`/`\t` is removed -- This means that the `patterns/0_*.txt` files can be removed. * this specific PR includes some shim content, in `allow/check-spelling-0.0.21.txt` -- once it this PR merges, it can be removed on a branch and the next CI will clean out items from `expect.txt` relating to the `\r` stuff and suggest replacement content. * talking to the bot is enabled for forks (but not the master repository) * SARIF reporting is enabled for PRs w/in a single repository (not across forks) * In job reports, there's a summary table (space permitting) linking to instances (this is a poor man's SARIF report) * When a pattern splits a thing that results in check-spelling finding an unrecognized token, that's reported with a distinct category * When there are items in expect that not longer match anything but more specific items do (e.g. `microsoft` vs. `Microsoft`), there's now a specific category with help/advice * Fancier excludes suggestions (excluding directories, file types, ...) * Refreshed dictionaries * The comment now links to the job summary (which includes SARIF link if available, the details view, and a generated commit that people can use if they're ok w/ the expect changes and don't want to run perl) ## Validation Steps Performed 1. the branch was developed in https://github.com/check-spelling-sandbox/terminal/actions?query=branch%3Acheck-spelling-0.0.22 2. ensuring compatibility with 0.0.21 was done in https://github.com/check-spelling-sandbox/terminal/pull/3 3. this version has been in development for a year and has quite a few improvements, we've been actively dogfooding it throughout this period 😄 ## PR Checklist - [ ] Closes #xxx - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:43:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#30845
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?