[PR #16970] Buffer Restore: Fix turning off intense/faint #31076

Open
opened 2026-01-31 09:44:55 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/16970

State: closed
Merged: Yes


This takes care of an edge case in regards to SGR 22: It turns off
both intense and faint attributes which means that we may need to
turn on one of the two if only one of them turned off.

Additionally, this removes the mapping for BottomGridline which
has no real VT equivalent anyway.

Validation Steps Performed

  • Turn session restore on
  • In pwsh write:
    "`e[1;2mboth`e[0;1mintense`e[m`n`e[1;2mboth`e[0;2mfaint`e[m"
    
  • Close the app and open the buffer_*.txt file next to settings.json
  • It contains... ✅
    ␛[1m␛[2mboth␛[22;1mintense␛[22m
    ␛[1m␛[2mboth␛[22;2mfaint␛[22m
    
**Original Pull Request:** https://github.com/microsoft/terminal/pull/16970 **State:** closed **Merged:** Yes --- This takes care of an edge case in regards to SGR 22: It turns off both intense and faint attributes which means that we may need to turn on one of the two if only one of them turned off. Additionally, this removes the mapping for `BottomGridline` which has no real VT equivalent anyway. ## Validation Steps Performed * Turn session restore on * In pwsh write: ```pwsh "`e[1;2mboth`e[0;1mintense`e[m`n`e[1;2mboth`e[0;2mfaint`e[m" ``` * Close the app and open the `buffer_*.txt` file next to settings.json * It contains... ✅ ``` ␛[1m␛[2mboth␛[22;1mintense␛[22m ␛[1m␛[2mboth␛[22;2mfaint␛[22m ```
claunia added the pull-request label 2026-01-31 09:44:55 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31076