starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #17638] Introduce the concept of "selection spans" instead of "rects" #31301

New Issue
Open
opened 2026-01-31 09:46:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:46:26 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/17638

State: closed
Merged: Yes

Right now, selections are stored as a set of points (start, end, pivot)
and converted into rectangles based on the contents of the screen buffer
every single render pass.

They are also painted fairly late in the rendering cycle.

This pull request makes a few changes to how selections happen.

Selections are now requested earlier in the rendering pass, during the
creation of the RenderInfo, and stored as a span<point_span>. To
make that span work, the selection data must be durably stored
somewhere.

Therefore, Terminal and conhost now take advantage of their new
generational selection data (#17676) to create and cache arrays of
point_spans covering their selections.

Unlike selection rects, linear (non-box) selections take only a single
entry in the span set. Also unlike selection rects, but like search
highlights, selection spans use buffer coordinates.

In the future, AtlasEngine can use the information sent in during
PrepareRenderInfo to influence text rendering decisions such as the
foreground and background color for a grapheme cluster or the gridlines.

Unfortunately, GDI is stuck with the old selection rendering
implementation and therefore, we still need to produce selection rects
with viewport coordinates and filter them down to the render engine's
dirty region. This is because GDI wants to invert all on-screen
pixels in the selection range after the final render to make sure
sixels, pixels, and lines are all displayed in the appropriate vintage
style.

As part of this change, I've migrated conhost's search highlight to not
read text directly out of the buffer but instead use the new
CopyRequest added by @tusharsnx in #16377.

Many of the tests for conhost behavior had a copy of conhost's code in
them, which sorta begs the question. I migrated them to use hardcoded
expected values to better catch regressions.

In Terminal, the "SelectAfterScroll" ControlCore tests weren't testing
anything they said they were, so I made them do so.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/17638 **State:** closed **Merged:** Yes --- Right now, selections are stored as a set of points (start, end, pivot) and converted into rectangles based on the contents of the screen buffer **every single render pass**. They are also painted fairly late in the rendering cycle. This pull request makes a few changes to how selections happen. Selections are now requested earlier in the rendering pass, during the creation of the `RenderInfo`, and stored as a `span<point_span>`. To make that `span` work, the selection data must be durably stored somewhere. Therefore, Terminal and conhost now take advantage of their new generational selection data (#17676) to create and cache arrays of `point_span`s covering their selections. Unlike selection rects, linear (non-box) selections take only a single entry in the span set. Also unlike selection rects, but _like_ search highlights, selection spans use buffer coordinates. In the future, AtlasEngine can use the information sent in during `PrepareRenderInfo` to influence text rendering decisions such as the foreground and background color for a grapheme cluster or the gridlines. Unfortunately, GDI is stuck with the old selection rendering implementation _and therefore, we still need to produce selection rects with viewport coordinates_ and filter them down to the render engine's dirty region. This is because GDI wants to **invert** all on-screen pixels in the selection range after the final render to make sure sixels, pixels, and lines are all displayed in the appropriate vintage style. As part of this change, I've migrated conhost's search highlight to not read text directly out of the buffer but instead use the new `CopyRequest` added by @tusharsnx in #16377. Many of the tests for conhost behavior had a copy of conhost's code in them, which sorta begs the question. I migrated them to use hardcoded expected values to better catch regressions. In Terminal, the "SelectAfterScroll" ControlCore tests weren't testing *anything* they said they were, so I made them do so.
claunia added the pull-request label 2026-01-31 09:46:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31301
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?