[PR #17647] Modernize VtPipeTerm #31305

Open
opened 2026-01-31 09:46:27 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/17647

State: closed
Merged: Yes


This shortens VtPipeTerm quite a bit, which used to have various debug
flags and modes. I kept the --out flag to redirect the output to a
file, but I removed the --debug (pipe the output through WSL and
show escape sequences visually) and --headless (hide conpty) flags.

I did this, because VtPipeTerm always used the system ConPTY API
but I needed it to use my local OpenConsole. I also wanted it to
use overlapped IO for testing but found that it was too difficult
to refactor make that work.

I also noticed that the project was the only holdout for
conpty.h which had to be kept in sync with winconpty.h.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/17647 **State:** closed **Merged:** Yes --- This shortens VtPipeTerm quite a bit, which used to have various debug flags and modes. I kept the `--out` flag to redirect the output to a file, but I removed the `--debug` (pipe the output through WSL and show escape sequences visually) and `--headless` (hide conpty) flags. I did this, because VtPipeTerm always used the system ConPTY API but I needed it to use my local OpenConsole. I also wanted it to use overlapped IO for testing but found that it was too difficult to refactor make that work. I also noticed that the project was the only holdout for `conpty.h` which had to be kept in sync with `winconpty.h`.
claunia added the pull-request label 2026-01-31 09:46:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31305