[PR #17654] Fix session restoration of full buffers #31309

Open
opened 2026-01-31 09:46:29 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/17654

State: closed
Merged: Yes


This removes the Terminal::SetViewportPosition call from session
restoration which was responsible for putting the viewport below
the buffer height and caused the renderer to fail.

In order to prevent such issues in the future, SetViewportPosition
now protects itself against out of bounds requests.

Closes #17639

Validation Steps Performed

  • Enable persistence
  • Print big.txt
  • Restart
  • Looks good ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/17654 **State:** closed **Merged:** Yes --- This removes the `Terminal::SetViewportPosition` call from session restoration which was responsible for putting the viewport below the buffer height and caused the renderer to fail. In order to prevent such issues in the future, `SetViewportPosition` now protects itself against out of bounds requests. Closes #17639 ## Validation Steps Performed * Enable persistence * Print `big.txt` * Restart * Looks good ✅
claunia added the pull-request label 2026-01-31 09:46:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31309