starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 16:34:42 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #17829] Avoid focus loops in ConPTY #31379

New Issue
Open
opened 2026-01-31 09:46:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:46:52 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/17829

State: closed
Merged: Yes

This fixes a lot of subtle issues:

  • Avoid emitting another de-/iconify VT sequence when
    we encounter a (de)iconify VT sequence during parsing.
  • Avoid emitting a de-/iconify VT sequence when
    a focus event is received on the signal pipe.
  • Avoid emitting such sequences on startup.
  • Avoid emitting multiple such sequences
    when rapidly un-/focusing the window.

It's also a minor cleanup, because the GA_ROOTOWNER is not security
relevant. It was added because there was concern that someone can just
spawn a ConPTY session, tell it that it's focused, and spawn a child
which is now focused. But why would someone do that, when the console
IOCTLs to do so are not just publicly available but also documented?

I also disabled the IME window.

Validation Steps Performed

  • First: 
    int main() {
    for (bool show = false;; show = !show) {
        printf(show ? "Show in 3s...\n" : "Hide in 3s...\n");
        Sleep(3000);
        ShowWindow(GetConsoleWindow(), show ? SW_SHOW : SW_HIDE);
    }
}
  • PowerShell 5's Get-Credential gains focus ✅
  • sleep 5; Get-Credential and focus another app. WT should start
    blinking in the taskbar. Restore it. The popup has focus ✅
  • Run :hardcopy in vim: Window is shown centered at (0,0) ✖️
    But that's okay because it does that already anyway ✅
  • Connect-AzAccount doesn't crash PowerShell ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/17829 **State:** closed **Merged:** Yes --- This fixes a lot of subtle issues: * Avoid emitting another de-/iconify VT sequence when we encounter a (de)iconify VT sequence during parsing. * Avoid emitting a de-/iconify VT sequence when a focus event is received on the signal pipe. * Avoid emitting such sequences on startup. * Avoid emitting multiple such sequences when rapidly un-/focusing the window. It's also a minor cleanup, because the `GA_ROOTOWNER` is not security relevant. It was added because there was concern that someone can just spawn a ConPTY session, tell it that it's focused, and spawn a child which is now focused. But why would someone do that, when the console IOCTLs to do so are not just publicly available but also documented? I also disabled the IME window. ## Validation Steps Performed * First: ```cpp int main() { for (bool show = false;; show = !show) { printf(show ? "Show in 3s...\n" : "Hide in 3s...\n"); Sleep(3000); ShowWindow(GetConsoleWindow(), show ? SW_SHOW : SW_HIDE); } } ``` * PowerShell 5's `Get-Credential` gains focus ✅ * `sleep 5; Get-Credential` and focus another app. WT should start blinking in the taskbar. Restore it. The popup has focus ✅ * Run `:hardcopy` in vim: Window is shown centered at (0,0) ✖️ But that's okay because it does that already anyway ✅ * `Connect-AzAccount` doesn't crash PowerShell ✅
claunia added the pull-request label 2026-01-31 09:46:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?