[PR #17983] Add Profile.BellSound to Settings UI #31415

Open
opened 2026-01-31 09:47:09 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/17983

State: closed
Merged: Yes


Summary of the Pull Request

Adds the Profile.BellSound setting to the Settings UI under the Profile > Advanced page.

  • View changes:
    • The setting is exposed via an expander placed near the Profile.BellStyle setting.
    • Added a button to be able to preview the added sound
    • Added a browse button that opens a file picker
    • Added a delete button to be able to delete each sound entry
  • View model changes:
    • CurrentBellSounds keeps track of the bell sounds added and exposed via the UI.
    • BellSoundViewModel wraps each sound. This allows us to listen (and propagate) changes to the registered sounds.
    • BellSoundPreview provides a written preview of the current bell sound to display in the expander

#10000

**Original Pull Request:** https://github.com/microsoft/terminal/pull/17983 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Adds the Profile.BellSound setting to the Settings UI under the Profile > Advanced page. - View changes: - The setting is exposed via an expander placed near the Profile.BellStyle setting. - Added a button to be able to preview the added sound - Added a browse button that opens a file picker - Added a delete button to be able to delete each sound entry - View model changes: - `CurrentBellSounds` keeps track of the bell sounds added and exposed via the UI. - `BellSoundViewModel` wraps each sound. This allows us to listen (and propagate) changes to the registered sounds. - `BellSoundPreview` provides a written preview of the current bell sound to display in the expander #10000
claunia added the pull-request label 2026-01-31 09:47:09 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31415