starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #18813] Add Badge to highlight new Extensions Page #31611

New Issue
Closed
opened 2026-01-31 09:48:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:48:23 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/18813

State: closed
Merged: No

Summary of the Pull Request

Adds a badge to the Extensions Page in the SUI's navigation pane to highlight that it's new!

References and Relevant Issues

Targets #18633

Detailed Description of the Pull Request / Additional comments

  • Settings Model changes:
    • Leveraged the ApplicationState class to track which badges have been dismissed and prevent them from appearing again
    • Used a std::unordered_set, but exposed a get and append function via the IDL
  • Settings UI changes:
    • Added a NewInfoBadge style that is just an InfoBadge with "NEW" in it instead of a number or an icon. Based on https://github.com/microsoft/PowerToys/pull/36939
    • The visibility is bound to a get call to the ApplicationState conducted via the ExtensionsPageViewModel. The VM is also responsible for updating the state.

Long-term, we can reuse this system and make the following minor changes:

  • SettingContainer: display the badge. and add logic to read/write ApplicationState appropriately (similarly to above)
  • XPageViewModel:
    • count all the badges that will be displayed and expose/bind that to InfoBadge.Value
    • If a whole page is new, we can just style the badge using the NewInfoBadge style

Validation Steps Performed

✅ Extensions page nav item displays a badge if page hasn't been visited
✅ The badge is dismissed when the user visits the page

**Original Pull Request:** https://github.com/microsoft/terminal/pull/18813 **State:** closed **Merged:** No --- ## Summary of the Pull Request Adds a badge to the Extensions Page in the SUI's navigation pane to highlight that it's new! ## References and Relevant Issues Targets #18633 ## Detailed Description of the Pull Request / Additional comments - Settings Model changes: - Leveraged the `ApplicationState` class to track which badges have been dismissed and prevent them from appearing again - Used a `std::unordered_set`, but exposed a `get` and `append` function via the IDL - Settings UI changes: - Added a `NewInfoBadge` style that is just an InfoBadge with "NEW" in it instead of a number or an icon. Based on https://github.com/microsoft/PowerToys/pull/36939 - The visibility is bound to a `get` call to the `ApplicationState` conducted via the `ExtensionsPageViewModel`. The VM is also responsible for updating the state. Long-term, we can reuse this system and make the following minor changes: - `SettingContainer`: display the badge. and add logic to read/write `ApplicationState` appropriately (similarly to above) - `XPageViewModel`: - count all the badges that will be displayed and expose/bind that to InfoBadge.Value - If a whole page is new, we can just style the badge using the `NewInfoBadge` style ## Validation Steps Performed ✅ Extensions page nav item displays a badge if page hasn't been visited ✅ The badge is dismissed when the user visits the page
claunia added the pull-request label 2026-01-31 09:48:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?