starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19133] Add scrollback source for suggestions #31716

New Issue
Closed
opened 2026-01-31 09:49:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:49:05 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19133

State: closed
Merged: No

Summary of the Pull Request

Adds scroll back source to suggestions

There were 2 things that are different about this from my original screenshot in the feature request.

  • In the feature request I had removed the MaxWidth on the _descriptionsBackdrop so that the control would expand for larger words. This helped for file paths, I decided to remove this change in case it affects the UX of the other sources.
  • In the feature request I had changed the color of the highlights to VsCode blue. When I tried this on a windows 10 machine I realized that the default accent color is blueish and the highlights were no longer visible so I reverted back to not setting the color.

I am not 100% sure on the performance of this. When I list out all of the paths in my home dir and search, the UI stutters in debug mode but doesn't in the release build. (I tried this on a really slow windows 10 machine with the release build and couldn't see any delay).

  • I think listing and searching all the paths in my home dir is close to the worst case scenario, there is a chance that the regex is set to something that brings back every cell as a word, which would cause there to be millions of words but they would be fast to search over.

https://github.com/user-attachments/assets/dfe6df2e-1faf-4fda-be50-76aca402e79e

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/19133 **State:** closed **Merged:** No --- ## Summary of the Pull Request Adds scroll back source to suggestions There were 2 things that are different about this from my original screenshot in the feature request. * In the feature request I had removed the MaxWidth on the _descriptionsBackdrop so that the control would expand for larger words. This helped for file paths, I decided to remove this change in case it affects the UX of the other sources. * In the feature request I had changed the color of the highlights to VsCode blue. When I tried this on a windows 10 machine I realized that the default accent color is blueish and the highlights were no longer visible so I reverted back to not setting the color. I am not 100% sure on the performance of this. When I list out all of the paths in my home dir and search, the UI stutters in debug mode but doesn't in the release build. (I tried this on a really slow windows 10 machine with the release build and couldn't see any delay). - I think listing and searching all the paths in my home dir is close to the worst case scenario, there is a chance that the regex is set to something that brings back every cell as a word, which would cause there to be millions of words but they would be fast to search over. https://github.com/user-attachments/assets/dfe6df2e-1faf-4fda-be50-76aca402e79e ## References and Relevant Issues ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed ## PR Checklist - [ ] Closes #19061 - [ ] Tests added/passed - [ ] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ ] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:49:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31716
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?