starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19425] fix(conpty): detect WSL switch when entered via command (fix #19420) #31837

New Issue
Open
opened 2026-01-31 09:49:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:49:52 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19425

State: closed
Merged: No

Summary

Fixes #19420 — Terminal Chat did not detect WSL when launched by running wsl inside an existing Windows shell.

Root cause

When a user launches wsl from an existing PowerShell/CMD session, the new WSL process runs as a child of the shell. Terminal previously only relied on the launched process at tab-creation to determine the environment and thus missed the manual wsl case.

Fix

  • Added WSL detection and environment-change notification to ConptyConnection::Start(). After launching the attached client, we check the commandline and set a _isWSLConnection flag and raise an _environmentChangedEventHandlers event when wsl is detected.
  • Declared the _isWSLConnection flag and _environmentChangedEventHandlers in ConptyConnection so other components (e.g., Terminal Chat) can subscribe and update context.

Files changed

  • src/cascadia/TerminalConnection/ConptyConnection.h (added _isWSLConnection flag and event)
  • src/cascadia/TerminalConnection/ConptyConnection.cpp (added detection logic after launching client)

Testing

  • Manual:

    1. Build and run local Windows Terminal.
    2. Open PowerShell tab, run wsl, open Terminal Chat — chat should now detect WSL (or logs show ConPtyDetectedWSLCommand event).
    3. Confirm launching WSL from the dropdown still behaves correctly.

  • CI: Unit tests touched are logic-only; no new flaky tests added.

Notes

  • The detection is a lightweight check of the commandline and raises an event for listeners; if maintainers prefer a different event system or WSL-detection utility, happy to adjust.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/19425 **State:** closed **Merged:** No --- ## Summary Fixes #19420 — Terminal Chat did not detect WSL when launched by running `wsl` inside an existing Windows shell. ### Root cause When a user launches `wsl` from an existing PowerShell/CMD session, the new WSL process runs as a child of the shell. Terminal previously only relied on the launched process at tab-creation to determine the environment and thus missed the manual `wsl` case. ### Fix - Added WSL detection and environment-change notification to `ConptyConnection::Start()`. After launching the attached client, we check the commandline and set a `_isWSLConnection` flag and raise an `_environmentChangedEventHandlers` event when `wsl` is detected. - Declared the `_isWSLConnection` flag and `_environmentChangedEventHandlers` in `ConptyConnection` so other components (e.g., Terminal Chat) can subscribe and update context. ### Files changed - `src/cascadia/TerminalConnection/ConptyConnection.h` (added _isWSLConnection flag and event) - `src/cascadia/TerminalConnection/ConptyConnection.cpp` (added detection logic after launching client) ### Testing - Manual: 1. Build and run local Windows Terminal. 2. Open PowerShell tab, run `wsl`, open Terminal Chat — chat should now detect WSL (or logs show `ConPtyDetectedWSLCommand` event). 3. Confirm launching WSL from the dropdown still behaves correctly. - CI: Unit tests touched are logic-only; no new flaky tests added. ### Notes - The detection is a lightweight check of the commandline and raises an event for listeners; if maintainers prefer a different event system or WSL-detection utility, happy to adjust.
claunia added the pull-request label 2026-01-31 09:49:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31837
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?