starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19504] Fix crash when canceling file picker in profile settings #31860

New Issue
Open
opened 2026-01-31 09:49:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:49:59 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19504

State: closed
Merged: No

Wraps SetClientGuid, SetFileTypes, and related dialog setup calls in try-catch blocks to prevent unhandled exceptions when the user cancels the file selection dialog or when dialog configuration fails.

Previously, if these operations threw an exception (which could happen during cancellation or in certain system states), it would crash the terminal. Now these operations are treated as non-fatal, allowing the dialog to still open even if some configuration steps fail.

Fixes #19501

Fix crash when canceling file picker in profile settings

Summary

Fixes a crash that occurs when users cancel the file selection dialog while setting the Command Line executable or Starting Directory for a profile.

References

Closes #19501

Detailed Description

When adding a new profile and clicking the browse button to select a Command Line executable or Starting Directory, canceling the file dialog would cause the terminal to crash. This happened because some of the file dialog configuration calls could throw exceptions that weren't being caught.

Changes Made

Added proper exception handling to the Commandline_Click and StartingDirectory_Click functions:

  • Wrapped SetClientGuid, SetFileTypes, and related calls in try-catch blocks
  • All caught exceptions are logged but treated as non-fatal
  • This matches the existing pattern used for SetDefaultFolder elsewhere in the codebase

Validation

  • Reproduced the original crash by canceling the file dialog
  • Verified the fix prevents the crash
  • Confirmed the file picker still works correctly when a file is selected

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/19504 **State:** closed **Merged:** No --- Wraps SetClientGuid, SetFileTypes, and related dialog setup calls in try-catch blocks to prevent unhandled exceptions when the user cancels the file selection dialog or when dialog configuration fails. Previously, if these operations threw an exception (which could happen during cancellation or in certain system states), it would crash the terminal. Now these operations are treated as non-fatal, allowing the dialog to still open even if some configuration steps fail. Fixes #19501 Fix crash when canceling file picker in profile settings ## Summary Fixes a crash that occurs when users cancel the file selection dialog while setting the Command Line executable or Starting Directory for a profile. ## References Closes #19501 ## Detailed Description When adding a new profile and clicking the browse button to select a Command Line executable or Starting Directory, canceling the file dialog would cause the terminal to crash. This happened because some of the file dialog configuration calls could throw exceptions that weren't being caught. ### Changes Made Added proper exception handling to the `Commandline_Click` and `StartingDirectory_Click` functions: - Wrapped `SetClientGuid`, `SetFileTypes`, and related calls in try-catch blocks - All caught exceptions are logged but treated as non-fatal - This matches the existing pattern used for `SetDefaultFolder` elsewhere in the codebase ## Validation - Reproduced the original crash by canceling the file dialog - Verified the fix prevents the crash - Confirmed the file picker still works correctly when a file is selected ## PR Checklist - [ X] Closes #19501 - [ x] Tests added/passed - [ x] Documentation updated - If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx - [ x] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:49:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?