starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19645] Refactor SCREEN_INFORMATION to use in-class initializers (#962) #31909

New Issue
Open
opened 2026-01-31 09:50:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:50:19 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19645

State: closed
Merged: Yes

Refactor SCREEN_INFORMATION Constructor Initializers

Summary

This PR refactors the legacy SCREEN_INFORMATION class to use in-class member initializers for members with constant or default values, replacing equivalent entries in the constructor initializer list.

This change aligns the class with C++ Core Guidelines C.48 (“Prefer in-class initializers to member initializers in constructors for constant initializers”) while preserving existing behavior.

Motivation

SCREEN_INFORMATION relied heavily on constructor member initializers for values that are constant or represent default state. This made it harder to reason about default object state and conflicted with the guideline the project references.

This PR addresses the issue in a minimal, mechanical, and well-scoped way, without attempting a broad codebase migration.

Changes

src/host/screenInfo.hpp

  • Added in-class default member initializers for members previously initialized with constant values.
  • Examples include:
    • WheelDelta, HWheelDelta
    • _textBuffer
    • Next
    • WriteConsoleDbcsLeadByte, FillOutDbcsLeadChar
    • ScrollScale
    • _api, _stateMachine
    • _psiAlternateBuffer, _psiMainBuffer
    • _fAltWindowChanged
    • _virtualBottom

src/host/screenInfo.cpp

  • Removed redundant constructor member initializers corresponding to the in-class defaults.
  • Members that depend on constructor parameters remain in the initializer list.

Verification

Automated Tests

  • Status: Not run
  • Reason: Build and test tools (msbuild, vstest.console.exe) are not available in the current environment.

Manual Verification

  • Performed strict code inspection to ensure a one-to-one correspondence between removed constructor initializers and added in-class initializers.
  • Verified that initialization semantics remain unchanged.

Notes

  • This is a mechanical refactor only; no functional or behavioral changes are intended.
  • No members with parameter-dependent initialization were moved to in-class initializers.
  • The scope is intentionally limited to a single legacy class and may serve as a reference for similar refactors in the future.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/19645 **State:** closed **Merged:** Yes --- ## Refactor `SCREEN_INFORMATION` Constructor Initializers ### Summary This PR refactors the legacy `SCREEN_INFORMATION` class to use **in-class member initializers** for members with constant or default values, replacing equivalent entries in the constructor initializer list. This change aligns the class with **C++ Core Guidelines C.48** (*“Prefer in-class initializers to member initializers in constructors for constant initializers”*) while preserving existing behavior. --- ### Motivation `SCREEN_INFORMATION` relied heavily on constructor member initializers for values that are constant or represent default state. This made it harder to reason about default object state and conflicted with the guideline the project references. This PR addresses the issue in a **minimal, mechanical, and well-scoped way**, without attempting a broad codebase migration. --- ### Changes #### `src/host/screenInfo.hpp` - Added in-class default member initializers for members previously initialized with constant values. - Examples include: - `WheelDelta`, `HWheelDelta` - `_textBuffer` - `Next` - `WriteConsoleDbcsLeadByte`, `FillOutDbcsLeadChar` - `ScrollScale` - `_api`, `_stateMachine` - `_psiAlternateBuffer`, `_psiMainBuffer` - `_fAltWindowChanged` - `_virtualBottom` #### `src/host/screenInfo.cpp` - Removed redundant constructor member initializers corresponding to the in-class defaults. - Members that depend on constructor parameters remain in the initializer list. --- ### Verification #### Automated Tests - **Status:** Not run - **Reason:** Build and test tools (`msbuild`, `vstest.console.exe`) are not available in the current environment. #### Manual Verification - Performed strict code inspection to ensure a one-to-one correspondence between removed constructor initializers and added in-class initializers. - Verified that initialization semantics remain unchanged. --- ### Notes - This is a **mechanical refactor** only; no functional or behavioral changes are intended. - No members with parameter-dependent initialization were moved to in-class initializers. - The scope is intentionally limited to a single legacy class and may serve as a reference for similar refactors in the future.
claunia added the pull-request label 2026-01-31 09:50:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?