starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

BUG: profiles.json values do not round trip properly #3191

New Issue
Closed
opened 2026-01-30 23:15:19 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 23:15:19 +00:00
Owner
Copy Link

Originally created by @kfarmer-msft on GitHub (Aug 6, 2019).

Environment

Windows build number:
Microsoft Windows [Version 10.0.18362.267]

Windows Terminal version (if applicable):
Windows Terminal (Preview)
Version: 0.3.2142.0

Any other software?
VS 2019 (though probably not relevant -- merely used this for editing profiles.json)

Steps to reproduce

Start terminal.
Edit profiles.json to give background image an opacity of 0.3 exactly:

            "backgroundImageOpacity" : 0.3,

Save.
Observe opacity change in running terminal.
Close profiles.json.
Close terminal.
Restart terminal.
Launch profiles.json from terminal.
Observe opacity value rewritten as

            "backgroundImageOpacity" : 0.30000001192092896,

Another case:

Set background image path to an interesting name, like:

            "backgroundImage" : "C:\\Users\\kfarm\\OneDrive\\Backgrounds\\Characters (Landscape)\\Þiálfi [Vizsla] - desktop.png",

It comes back as

            "backgroundImage" : "C:\\Users\\kfarm\\OneDrive\\Backgrounds\\Characters (Landscape)\\\u00dei\u00e1lfi [Vizsla] - desktop.png",

Expected behavior

All values round-trip, retaining the actual value from the file, unless the value was explicitly changed as a result of user action.

Actual behavior

Arguably, data corruption. The values still work, technically, but they are not what the user specified. A failure to properly re-encode will lose data. Better to leave the original values untouched.

Related: If I omit a profile GUID, why add one to the file? Pick one on load and use it internally, but unless it's getting referenced elsewhere in the file, why have it at all?

Originally created by @kfarmer-msft on GitHub (Aug 6, 2019). # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.267] Windows Terminal version (if applicable): Windows Terminal (Preview) Version: 0.3.2142.0 Any other software? VS 2019 (though probably not relevant -- merely used this for editing profiles.json) ``` # Steps to reproduce Start terminal. Edit profiles.json to give background image an opacity of 0.3 exactly: ```none "backgroundImageOpacity" : 0.3, ``` Save. Observe opacity change in running terminal. Close profiles.json. Close terminal. Restart terminal. Launch profiles.json from terminal. Observe opacity value rewritten as ```none "backgroundImageOpacity" : 0.30000001192092896, ``` Another case: Set background image path to an interesting name, like: ```none "backgroundImage" : "C:\\Users\\kfarm\\OneDrive\\Backgrounds\\Characters (Landscape)\\Þiálfi [Vizsla] - desktop.png", ``` It comes back as ```none "backgroundImage" : "C:\\Users\\kfarm\\OneDrive\\Backgrounds\\Characters (Landscape)\\\u00dei\u00e1lfi [Vizsla] - desktop.png", ``` # Expected behavior All values round-trip, retaining the actual value from the file, unless the value was explicitly changed as a result of user action. # Actual behavior Arguably, data corruption. The values still *work*, technically, but they are not what the user specified. A failure to properly re-encode will lose data. Better to leave the original values untouched. Related: If I omit a profile GUID, why add one to the file? Pick one on load and use it internally, but unless it's getting referenced elsewhere in the file, why have it at all?
claunia commented 2026-01-30 23:15:20 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 8, 2019):

This is tracked in #1398 . We may want to make all opacities and percentages integral anyway like we did for cursorHeight.

@DHowett-MSFT commented on GitHub (Aug 8, 2019): This is tracked in #1398 . We may want to make all opacities and percentages integral anyway like we did for `cursorHeight`.
claunia commented 2026-01-30 23:15:20 +00:00
Author
Owner
Copy Link

@surfer776 commented on GitHub (Aug 17, 2019):

.

mascouten777@gmail.com

On Wed, Aug 7, 2019, 7:45 PM Dustin L. Howett (MSFT) <
notifications@github.com> wrote:

Closed #2280 https://github.com/microsoft/terminal/issues/2280.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/2280?email_source=notifications&email_token=ALW6QYJHWSVM7LRTPGZ4HZLQDNUDRA5CNFSM4IJT2XZKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS6AD4MA#event-2541764144,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALW6QYP7IFBDCH4FJTAJKWLQDNUDRANCNFSM4IJT2XZA
.

@surfer776 commented on GitHub (Aug 17, 2019): . mascouten777@gmail.com On Wed, Aug 7, 2019, 7:45 PM Dustin L. Howett (MSFT) < notifications@github.com> wrote: > Closed #2280 <https://github.com/microsoft/terminal/issues/2280>. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/microsoft/terminal/issues/2280?email_source=notifications&email_token=ALW6QYJHWSVM7LRTPGZ4HZLQDNUDRA5CNFSM4IJT2XZKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS6AD4MA#event-2541764144>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ALW6QYP7IFBDCH4FJTAJKWLQDNUDRANCNFSM4IJT2XZA> > . >
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Triage Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3191
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?