starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19761] Add support for Include directive in SSH config parser (#19555) #31956

New Issue
Open
opened 2026-01-31 09:50:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:50:36 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19761

State: open
Merged: No

Summary of the Pull Request

Adds support for the Include directive in SSH config parser, enabling Terminal to generate profiles from split SSH configuration files (e.g., Include config.d/*).

References and Relevant Issues

Fixes #19555

Detailed Description of the Pull Request / Additional comments

This PR implements SSH config Include directive support with the following features:

Changes:

  • Added Include directive parsing in SshHostGenerator::_getHostNamesFromConfigFile()
  • Implemented _processIncludeDirective() to handle file inclusion with wildcard pattern support
  • Added _matchesPattern() for wildcard matching (* and ? patterns)
  • Recursively processes included config files relative to the parent config directory

Behavior:

  • Supports direct includes: Include ~/.ssh/config.d/work
  • Supports wildcard includes: Include config.d/*
  • Handles relative paths from config file location
  • Maintains backward compatibility with existing configs

Implementation:

  • Modified: SshHostGenerator.cpp (+107 lines)
  • Modified: SshHostGenerator.h (+2 function declarations)

Validation Steps Performed

  • Tested with direct file includes
  • Tested with wildcard patterns (config.d/*)
  • Verified recursive parsing of included files
  • Confirmed profiles generated correctly from split configs

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/19761 **State:** open **Merged:** No --- ## Summary of the Pull Request Adds support for the `Include` directive in SSH config parser, enabling Terminal to generate profiles from split SSH configuration files (e.g., `Include config.d/*`). ## References and Relevant Issues Fixes #19555 ## Detailed Description of the Pull Request / Additional comments This PR implements SSH config `Include` directive support with the following features: **Changes:** - Added `Include` directive parsing in `SshHostGenerator::_getHostNamesFromConfigFile()` - Implemented `_processIncludeDirective()` to handle file inclusion with wildcard pattern support - Added `_matchesPattern()` for wildcard matching (`*` and `?` patterns) - Recursively processes included config files relative to the parent config directory **Behavior:** - Supports direct includes: `Include ~/.ssh/config.d/work` - Supports wildcard includes: `Include config.d/*` - Handles relative paths from config file location - Maintains backward compatibility with existing configs **Implementation:** - Modified: `SshHostGenerator.cpp` (+107 lines) - Modified: `SshHostGenerator.h` (+2 function declarations) ## Validation Steps Performed - Tested with direct file includes - Tested with wildcard patterns (`config.d/*`) - Verified recursive parsing of included files - Confirmed profiles generated correctly from split configs ## PR Checklist - [x] Closes #19555 - [ ] Tests added/passed - [ ] Documentation updated - [ ] Schema updated (if necessary)
claunia added the pull-request label 2026-01-31 09:50:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?