starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19789] Add focusBellTab action to navigate to tabs with bell indicators #31961

New Issue
Open
opened 2026-01-31 09:50:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:50:37 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19789

State: open
Merged: No

Summary

Adds a new focusBellTab action that navigates to the next tab showing a bell indicator (🔔).

Fixes #19788

Changes

File Change
AllShortcutActions.h Register FocusBellTab action
ActionAndArgs.cpp Add focusBellTabKey mapping
AppActionHandlers.cpp Implement _HandleFocusBellTab handler
defaults.json Add command with Ctrl+Shift+B keybinding
Resources.resw Add "Focus next bell tab" string

Behavior

  • Finds next tab (by index) with BellIndicator == true
  • Wraps around to beginning if needed
  • Repeated presses cycle through all bell tabs
  • Does nothing if no bells are active

Implementation Details

~40 lines of new code. The handler iterates _tabs checking TabStatus().BellIndicator():

for (uint32_t offset = 1; offset <= tabCount; offset++)
{
    const auto idx = (currentIdx + offset) % tabCount;
    if (tab->TabStatus().BellIndicator())
    {
        _SelectTab(idx);
        return;
    }
}

Validation

  • Builds successfully (ARM64 Release)
  • Manual testing with bell triggers
  • Keybinding works (Ctrl+Shift+B)
  • Command palette shows "Focus next bell tab"

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/19789 **State:** open **Merged:** No --- ## Summary Adds a new `focusBellTab` action that navigates to the next tab showing a bell indicator (🔔). **Fixes #19788** ## Changes | File | Change | |------|--------| | `AllShortcutActions.h` | Register `FocusBellTab` action | | `ActionAndArgs.cpp` | Add `focusBellTabKey` mapping | | `AppActionHandlers.cpp` | Implement `_HandleFocusBellTab` handler | | `defaults.json` | Add command with `Ctrl+Shift+B` keybinding | | `Resources.resw` | Add "Focus next bell tab" string | ## Behavior - Finds next tab (by index) with `BellIndicator == true` - Wraps around to beginning if needed - Repeated presses cycle through all bell tabs - Does nothing if no bells are active ## Implementation Details ~40 lines of new code. The handler iterates `_tabs` checking `TabStatus().BellIndicator()`: ```cpp for (uint32_t offset = 1; offset <= tabCount; offset++) { const auto idx = (currentIdx + offset) % tabCount; if (tab->TabStatus().BellIndicator()) { _SelectTab(idx); return; } } ``` ## Validation - [x] Builds successfully (ARM64 Release) - [ ] Manual testing with bell triggers - [ ] Keybinding works (Ctrl+Shift+B) - [ ] Command palette shows "Focus next bell tab" ## PR Checklist - [x] Closes #19788 - [ ] Tests added/passed - [ ] Documentation updated - [ ] Schema updated (not necessary)
claunia added the pull-request label 2026-01-31 09:50:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?