starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #19805] Add periodic buffer persistence to protect against unexpected termination #31965

New Issue
Open
opened 2026-01-31 09:50:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:50:39 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/19805

State: open
Merged: No

Summary

This PR adds periodic buffer persistence to protect against unexpected termination (BSOD, power failure, Task Manager kill).

Fixes #19804

The Problem

Previously, terminal buffer content was only persisted on graceful exit:

  • At end of message loop (normal quit)
  • On WM_ENDSESSION (graceful OS shutdown)

The 5-minute persistence timer only saved layout (tabs, panes, positions), not buffer content. This meant:

What Gets Saved When Survives Unexpected Termination
Tab layout Every 5 minutes ✅ Yes
Buffer content Only on graceful exit ❌ No

Users running long-lived sessions (Claude Code, SSH, development environments) would lose hours of terminal history on crash, even though tabs appeared to be "restored."

The Solution

  • Extract buffer persistence into a new _persistBuffers() function
  • Call _persistBuffers() on the existing 5-minute persistence timer
  • Refactor _finalizeSessionPersistence() to use the shared function

Now buffer content is saved every 5 minutes alongside layout.

Validation Steps Performed

  • Code review for correctness
  • Verified refactored _finalizeSessionPersistence() maintains cleanup behavior
  • Confirmed _persistBuffers() respects FirstWindowPreference::PersistedLayoutAndContent setting

PR Checklist

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/microsoft/terminal/pull/19805 **State:** open **Merged:** No --- ## Summary This PR adds periodic buffer persistence to protect against unexpected termination (BSOD, power failure, Task Manager kill). Fixes #19804 ### The Problem Previously, terminal buffer content was only persisted on graceful exit: - At end of message loop (normal quit) - On `WM_ENDSESSION` (graceful OS shutdown) The 5-minute persistence timer only saved **layout** (tabs, panes, positions), not buffer content. This meant: | What Gets Saved | When | Survives Unexpected Termination | |-----------------|------|--------------------------------| | Tab layout | Every 5 minutes | ✅ Yes | | Buffer content | Only on graceful exit | ❌ **No** | Users running long-lived sessions (Claude Code, SSH, development environments) would lose hours of terminal history on crash, even though tabs appeared to be "restored." ### The Solution - Extract buffer persistence into a new `_persistBuffers()` function - Call `_persistBuffers()` on the existing 5-minute persistence timer - Refactor `_finalizeSessionPersistence()` to use the shared function Now buffer content is saved every 5 minutes alongside layout. ## Validation Steps Performed - [x] Code review for correctness - [x] Verified refactored `_finalizeSessionPersistence()` maintains cleanup behavior - [x] Confirmed `_persistBuffers()` respects `FirstWindowPreference::PersistedLayoutAndContent` setting ## PR Checklist - [x] Closes #19804 - [x] Tests added/passed (N/A - existing persistence tests cover this code path) - [x] Documentation updated (N/A - no user-facing changes, existing setting controls behavior) - [x] Schema updated (N/A - no new settings) --- 🤖 Generated with [Claude Code](https://claude.ai/code)
claunia added the pull-request label 2026-01-31 09:50:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#31965
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?