Ctrl C, when text is highlighted, should copy not cancel #3199

@zadjii-msft commented on GitHub (Aug 6, 2019):

Don't do that, just add a keybinding for copy (that was my bad the action is copy not copyText).

{ "command": "copy", "keys": ["ctrl+c"] },
{ "command": "paste", "keys": ["ctrl+v"] }

should do the trick.

You can set the keybinding to whatever you want. Ctrl+C, Ctrl+Shift+C, Shift+Insert.

@zadjii-msft commented on GitHub (Aug 6, 2019): Don't do that, just add a keybinding for `copy` (that was my bad the action is `copy` not `copyText`). ```json { "command": "copy", "keys": ["ctrl+c"] }, { "command": "paste", "keys": ["ctrl+v"] } ``` should do the trick. You can set the keybinding to whatever you want. Ctrl+C, Ctrl+Shift+C, Shift+Insert.

claunia commented

@mikemaccana commented on GitHub (Aug 6, 2019):

@zadjii-msft Done - adding that keybinding stops Ctrl C from cancelling when text is selected (yaay) but breaks cancelling when text isn't selected.

@mikemaccana commented on GitHub (Aug 6, 2019): @zadjii-msft Done - adding that keybinding stops Ctrl C from cancelling when text is selected (yaay) but breaks cancelling when text isn't selected.

claunia commented

@mikemaccana commented on GitHub (Aug 6, 2019):

The comment mentioned earlier indicates a lot of other people have the same idea: https://github.com/microsoft/terminal/issues/968#issuecomment-495935319

Ctrl+C only copies when something is selected. If nothing is selected then Ctrl+C behaves as usual and sends an SIGINT.

There's 25 thumbs up.

@mikemaccana commented on GitHub (Aug 6, 2019): The comment mentioned earlier indicates a lot of other people have the same idea: https://github.com/microsoft/terminal/issues/968#issuecomment-495935319 > Ctrl+C only copies when something is selected. If nothing is selected then Ctrl+C behaves as usual and sends an SIGINT. There's 25 thumbs up.

claunia commented

@zadjii-msft commented on GitHub (Aug 6, 2019):

I'm gonna summon @carlos-zamora.

I thought we made copy only work if there was a selection, but I guess we still eat the keystroke. Maybe we shouldn't.

@zadjii-msft commented on GitHub (Aug 6, 2019): I'm gonna summon @carlos-zamora. I thought we made copy only work if there was a selection, but I guess we still eat the keystroke. Maybe we shouldn't.

claunia commented

@Renha commented on GitHub (Aug 6, 2019):

you definitely should, keyboard input shouldn't depend on mouse input - user shouldn't waste time to grab a mouse for deselection if she needs to stop some program

@Renha commented on GitHub (Aug 6, 2019): you definitely should, keyboard input shouldn't depend on mouse input - user shouldn't waste time to grab a mouse for deselection if she needs to stop some program

claunia commented

@mikemaccana commented on GitHub (Aug 6, 2019):

Various thoughts:

25 people voted for making Ctrl C copy if selected, cancel if not selected in the thread above
User can just bang Ctrl C and stop the program in most cases, deselection would only be needed if they explicitly selected something first.
Additionally, even if they had selected something, hitting Ctrl C twice would deselect/copy and then cancel
We could always make it configurable.

@mikemaccana commented on GitHub (Aug 6, 2019): Various thoughts: - 25 people voted for making Ctrl C copy if selected, cancel if not selected in the thread above - User can just bang Ctrl C and stop the program in most cases, deselection would only be needed if they explicitly selected something first. - Additionally, even if they had selected something, hitting Ctrl C twice would deselect/copy and then cancel - We could always make it configurable.

claunia commented

@carlos-zamora commented on GitHub (Aug 6, 2019):

As of now, we still have keystrokes eating the escape sequence. So you either have a keystroke hooked up to a command, or it emmits the escape sequence. Though it isn't ideal, the current workaround is to bind "copy" to something that won't conflict with the escape sequence you want to emit.

Though making a kind of "smart copy" would work (and I'm adding it to the coming milestone), this does show that there is a bigger issue: how can you emit escape sequences when keystrokes are bound to an action?

Accessibility was top-priority for me last month. Now that we have a somewhat working model (still plenty of work to do there), I'm hoping to spend more time shared between interactivity and accessibility. Please be patient and respectful as we make progress. We do accept PRs, as we can't get to everything between releases.

@carlos-zamora commented on GitHub (Aug 6, 2019): As of now, we still have keystrokes eating the escape sequence. So you either have a keystroke hooked up to a command, or it emmits the escape sequence. Though it isn't ideal, the current workaround is to bind "copy" to something that won't conflict with the escape sequence you want to emit. Though making a kind of "smart copy" would work (and I'm adding it to the coming milestone), this does show that there is a bigger issue: how can you emit escape sequences when keystrokes are bound to an action? Accessibility was top-priority for me last month. Now that we have a somewhat working model (still plenty of work to do there), I'm hoping to spend more time shared between interactivity and accessibility. Please be patient and respectful as we make progress. We do accept PRs, as we can't get to everything between releases.

claunia commented

@miniksa commented on GitHub (Aug 6, 2019):

I can only assume it's being blocked by either ego or some internal spaghetti code.

@CobusKruger, please let me refresh you on the Microsoft Open Source Code of Conduct. We can disagree here and have debates, but please halt yourself before assuming the motivations of others and attacking individuals personally or their work.

We are happy to continue to discuss the way that this prerelease product should evolve before it meets v1.0 (and even after 1.0!) Please exercise patience and understanding when working with us and members of the community as the software develops.

@miniksa commented on GitHub (Aug 6, 2019): > I can only assume it's being blocked by either ego or some internal spaghetti code. @CobusKruger, please let me refresh you on the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). We can disagree here and have debates, but please halt yourself before assuming the motivations of others and attacking individuals personally or their work. We are happy to continue to discuss the way that this prerelease product should evolve before it meets v1.0 (and even after 1.0!) Please exercise patience and understanding when working with us and members of the community as the software develops.

claunia commented

@DHowett-MSFT commented on GitHub (Aug 6, 2019):

Design notes:
Each key binding handler needs to be augmented with a sender (maybe) and an event args (definitely). The event args should have a Handled() just like the key events at the Xaml layer.
This will let the Copy/Paste/MoveToTab (etc.) handlers report whether they did anything in response to the event being raised.
If a handler replies in the negatory, the event should fall through to the standard handlers.

Potential complexity:
We should be using event args to communicate everything about an event. For copy, that includes "filter newlines," and for "new tab" that includes "which profile index." We may cause a bit of an explosion in event argument types.

This will tie in with @zadjii-msft's work on key binding arguments, and may be a step towards implementing it.

@DHowett-MSFT commented on GitHub (Aug 6, 2019): Design notes: Each key binding handler needs to be augmented with a sender (maybe) and an event args (definitely). The event args should have a `Handled()` just like the key events at the Xaml layer. This will let the Copy/Paste/MoveToTab (etc.) handlers report whether they _did anything_ in response to the event being raised. If a handler replies in the negatory, the event should fall through to the standard handlers. Potential complexity: We should be using event args to communicate _everything_ about an event. For copy, that includes "filter newlines," and for "new tab" that includes "which profile index." We may cause a bit of an explosion in event argument types. This will tie in with @zadjii-msft's work on key binding arguments, and may be a step towards implementing it.

claunia commented

@zadjii-msft commented on GitHub (Aug 6, 2019):

@DHowett-MSFT I'm pretty sure you just described like 80% of what #1349 has in it

@zadjii-msft commented on GitHub (Aug 6, 2019): @DHowett-MSFT I'm pretty sure you just described like 80% of what #1349 has in it

claunia commented

@ViktorHofer commented on GitHub (Aug 7, 2019):

I don't understand the downvotes in the initial post. The described expected behavior is how cmd works today in Windows. An entire booth at the #build conference celebrated when the copy cmd+c functionality was announced.

@ViktorHofer commented on GitHub (Aug 7, 2019): I don't understand the downvotes in the initial post. The described expected behavior is how cmd works today in Windows. An entire booth at the #build conference celebrated when the copy cmd+c functionality was announced.

claunia commented

@jtleaming commented on GitHub (Aug 7, 2019):

I noticed selecting text with the mouse and copying works, but if I select the text using the cursor (shift+arrow-key) and then copy, nothing seems to be copied. Maybe shift+arrow-key doesn't seem to be selecting like I thought, but the issue seems to be related.

@jtleaming commented on GitHub (Aug 7, 2019): I noticed selecting text with the mouse and copying works, but if I select the text using the cursor (shift+arrow-key) and then copy, nothing seems to be copied. Maybe shift+arrow-key doesn't seem to be selecting like I thought, but the issue seems to be related.

claunia commented

@ryzngard commented on GitHub (Aug 8, 2019):

@DHowett-MSFT based on the design notes, should we follow #1349 to monitor this becoming available?

@ryzngard commented on GitHub (Aug 8, 2019): @DHowett-MSFT based on the design notes, should we follow #1349 to monitor this becoming available?

claunia commented

@Pilchie commented on GitHub (Aug 8, 2019):

The lack of this paired with the poor formatting of pasting copied text from terminal into other apps has basically been a blocker to me adopting it. The improvements in conhost of the last few years have been so great, it's been impossible to go backwards.

@Pilchie commented on GitHub (Aug 8, 2019): The lack of this paired with the poor formatting of pasting copied text from terminal into other apps has basically been a blocker to me adopting it. The improvements in conhost of the last few years have been so great, it's been impossible to go backwards.

claunia commented