Feature Request - use a directory for profiles #3219

@DHowett-MSFT commented on GitHub (Aug 8, 2019):

The more I think about this, the more I like the idea of dovetailing it with the dynamic profile specification from #754 😄

@DHowett-MSFT commented on GitHub (Aug 8, 2019): The more I think about this, the more I like the idea of dovetailing it with the dynamic profile specification from #754 :smile:

claunia commented

@dbacher commented on GitHub (Aug 8, 2019):

The reason that I suggested this is there is an easy rule for many developers. The easier something is to do, the more likely they do it. Every installer can copy a file, every uninstaller can delete a file. However, modifying a JSON file? Not so much.
If I'm JASC and I'm writing 4NT (yeah, I know old school), if my installer just has to copy a file - I'm likely to do that. IF you use this approach, you might want a version tag as well.

@dbacher commented on GitHub (Aug 8, 2019): The reason that I suggested this is there is an easy rule for many developers. The easier something is to do, the more likely they do it. Every installer can copy a file, every uninstaller can delete a file. However, modifying a JSON file? Not so much. If I'm JASC and I'm writing 4NT (yeah, I know old school), if my installer just has to copy a file - I'm likely to do that. IF you use this approach, you might want a version tag as well.

claunia commented

@ffes commented on GitHub (Aug 8, 2019):

And let the user define extra locations (yes, plural) , like \\server\share\path or %USERPROFILE%\OneDrive\SomePath where profiles are being searched for as well

@ffes commented on GitHub (Aug 8, 2019): And let the user define extra locations (yes, plural) , like `\\server\share\path` or `%USERPROFILE%\OneDrive\SomePath` where profiles are being searched for as well

claunia commented

@zadjii-msft commented on GitHub (Aug 8, 2019):

I'm pretty specifically leaving out having more locations for settings files from the #1258 spec. It's definitely something I've been thinking about, but I'm afraid that adding that section would delay delivering the basic User+Default settings by a few months.

This is definitely a good idea, but lets please not rope it in with #754 :)

@zadjii-msft commented on GitHub (Aug 8, 2019): I'm pretty specifically leaving out having more locations for settings files from the #1258 spec. It's definitely something I've been thinking about, but I'm afraid that adding that section would delay delivering the basic User+Default settings by a few months. This is definitely a good idea, but lets please not rope it in with #754 :)

claunia commented

@DHowett-MSFT commented on GitHub (Aug 8, 2019):

Just following up: we chatted o*line -- the intent was not to combine it with #754, just to say that #754 will make this infinitely easier.

@DHowett-MSFT commented on GitHub (Aug 8, 2019): Just following up: we chatted o*line -- the intent was not to combine it with #754, just to say that #754 will make this _infinitely easier_.

claunia commented

@jantari commented on GitHub (Aug 18, 2019):

This could be done in the Linux-way too:

Master/default settings file is:

%path%/profiles.json

But every json file inside this directory is also parsed in alphabetical order and may overwrite the settings set in the master file:

%path%/profiles.d/10-anything.json
%path%/profiles.d/20-anything.json
%path%/profiles.d/99-anything.json

This approach is familiar to most people who have used a linux-based OS before as many standard utils handle their configuration in this manner and it would work on Windows just the same.

@jantari commented on GitHub (Aug 18, 2019): This could be done in the Linux-way too: Master/default settings file is: ``` %path%/profiles.json ``` But every json file inside this directory is also parsed in alphabetical order and may overwrite the settings set in the master file: ``` %path%/profiles.d/10-anything.json %path%/profiles.d/20-anything.json %path%/profiles.d/99-anything.json ``` This approach is familiar to most people who have used a linux-based OS before as many standard utils handle their configuration in this manner and it would work on Windows just the same.

claunia commented

@zadjii-msft commented on GitHub (Sep 9, 2019):

For linking purposes, this seems related to #1690

@zadjii-msft commented on GitHub (Sep 9, 2019): For linking purposes, this seems related to #1690

claunia commented

@deoradh commented on GitHub (Feb 20, 2020):

I really want the ability to easily backup my settings (eg, to OneDrive), and this provides a way to do so.

One suggestion:

Include the ability to override the settings location via the command line (and being able to use this as a shortcut). That would be useful for defining sets of profiles and store them in source control or on a network share. I'm sure we've all used special command line shortcuts in the past...

@deoradh commented on GitHub (Feb 20, 2020): I *really* want the ability to easily backup my settings (eg, to OneDrive), and this provides a way to do so. One suggestion: - Include the ability to override the settings location via the command line (and being able to use this as a shortcut). That would be useful for defining sets of profiles and store them in source control or on a network share. I'm sure we've all used special command line shortcuts in the past...

claunia commented

@zadjii-msft commented on GitHub (May 6, 2021):

Hey wait, isn't this exactly what we did with #1690, #7584, #7632, https://docs.microsoft.com/en-us/windows/terminal/json-fragment-extensions?

We could keep using #2933 for "let the user specify another path to load settings from". But I think the fundamental premise of

That would allow an installer from another team, for example from Visual Studio, Azure, etc. to hang a profile just by copying in a file like visual-studio-2019-cmd-tools.json or windows-platform-sdk.json.

is covered now, yea?

@zadjii-msft commented on GitHub (May 6, 2021): Hey wait, isn't this exactly what we did with #1690, #7584, #7632, https://docs.microsoft.com/en-us/windows/terminal/json-fragment-extensions? We could keep using #2933 for "let the user specify another path to load settings from". But I think the fundamental premise of > That would allow an installer from another team, for example from Visual Studio, Azure, etc. to hang a profile just by copying in a file like visual-studio-2019-cmd-tools.json or windows-platform-sdk.json. is covered now, yea?

claunia commented

@zadjii-msft commented on GitHub (Dec 8, 2021):

(I'm gonna answer my own question: yes, it is covered now)

@zadjii-msft commented on GitHub (Dec 8, 2021): (I'm gonna answer my own question: yes, it is covered now)

claunia commented

@dbacher commented on GitHub (Dec 8, 2021):

Sorry, had meant to confirm this a long time ago and got distracted by other things. Indeed, this is addressed by the changes you've made to the terminal client.

@dbacher commented on GitHub (Dec 8, 2021): Sorry, had meant to confirm this a long time ago and got distracted by other things. Indeed, this is addressed by the changes you've made to the terminal client.

claunia commented