starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

BUG - ConhostConnection post 0da13cdf2d causes app to crash #3255

New Issue
Closed
opened 2026-01-30 23:17:02 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:17:02 +00:00
Owner
Copy Link

Originally created by @Jewsh-S on GitHub (Aug 7, 2019).

Environment

Version: 1903
OS BUILD: 18362.10006 (Microsoft Windows [Version 10.0.18362.10006])

Windows Terminal version (if applicable):

Any other software?


# Steps to reproduce

Build code from 42c1e58966b50c72039808b09b663b74180519ce and the build completes, but when I start the app, I get failures and app just instantly closes out.
If I restore the file (src/cascadia/TerminalConnection/ConhostConnection.cpp) from 0da13cdf2d5ba2081f12f85f6816546489d4918b to any newer code then build succeeds and the app starts normally
# Expected behavior
I expect the newer version of src/cascadia/TerminalConnection/ConhostConnection.cpp to not cause the app to crash on startup

<!-- A description of what you're expecting, possibly containing screenshots or reference material. -->
I start the app with newest code and app crashes.  But when I restore the file of src/cascadia/TerminalConnection/ConhostConnection.cpp to pre 42c1e58966b50c72039808b09b663b74180519ce version, everything works fine.

# Actual behavior

The app crashes when I use the latest code of src/cascadia/TerminalConnection/ConhostConnection.cpp
Originally created by @Jewsh-S on GitHub (Aug 7, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Version: 1903 OS BUILD: 18362.10006 (Microsoft Windows [Version 10.0.18362.10006]) Windows Terminal version (if applicable): Any other software? ``` # Steps to reproduce Build code from 42c1e58966b50c72039808b09b663b74180519ce and the build completes, but when I start the app, I get failures and app just instantly closes out. If I restore the file (src/cascadia/TerminalConnection/ConhostConnection.cpp) from 0da13cdf2d5ba2081f12f85f6816546489d4918b to any newer code then build succeeds and the app starts normally # Expected behavior I expect the newer version of src/cascadia/TerminalConnection/ConhostConnection.cpp to not cause the app to crash on startup <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> I start the app with newest code and app crashes. But when I restore the file of src/cascadia/TerminalConnection/ConhostConnection.cpp to pre 42c1e58966b50c72039808b09b663b74180519ce version, everything works fine. # Actual behavior The app crashes when I use the latest code of src/cascadia/TerminalConnection/ConhostConnection.cpp
claunia commented 2026-01-30 23:17:04 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 8, 2019):

@jewsh-s thanks for the report. Since you're comfortable producing local builds with specific commits included/excluded, I'm hoping you're comfortable enough to provide a stack trace or a crash site?
Thanks.

@DHowett-MSFT commented on GitHub (Aug 8, 2019): @jewsh-s thanks for the report. Since you're comfortable producing local builds with specific commits included/excluded, I'm hoping you're comfortable enough to provide a stack trace or a crash site? Thanks.
claunia commented 2026-01-30 23:17:04 +00:00
Author
Owner
Copy Link

@Jewsh-S commented on GitHub (Aug 9, 2019):

Sorry for the latest reply here. Yes I am okay doing this. I restored the file to what it should be on the latest branch (1e4e12507d) and ran a new build.

To run a new build, I usually like to build from command prompt using .\tools\razzle.cmd; bcz

Then I open OpenConsole.sln in VS and run for X64. When I restore the file to pre 0da13cdf2d I get a build succeed, but anything after that commit and I get the following: (same results with the latest build today). Sorry if this is all confusing. I will also post a screenshot VS at point of failure. See below for trace.

Microsoft.Toolkit.Win32.UI.XamlHost.dll!00007fff096f3879() Unknown
Windows.UI.Xaml.dll!00007fff12a4704d() Unknown
Windows.UI.Xaml.dll!00007fff1282398c() Unknown
Windows.UI.Xaml.dll!00007fff12938589() Unknown
Windows.UI.Xaml.dll!00007fff12932e7b() Unknown
ntdll.dll!00007fff2e0a5031() Unknown
ntdll.dll!00007fff2e0eaaa2() Unknown
ntdll.dll!00007fff2e0ea94d() Unknown
kernel32.dll!00007fff2c5acd8a() Unknown
ucrtbased.dll!00007ffec8d0467a() Unknown
ucrtbased.dll!00007ffec8d04629() Unknown
ucrtbased.dll!00007ffec8d049a6() Unknown
WindowsTerminal.exe!__scrt_common_main_seh() Line 297 C++
WindowsTerminal.exe!__scrt_common_main() Line 331 C++
WindowsTerminal.exe!wWinMainCRTStartup() Line 17 C++
kernel32.dll!00007fff2c5a7bd4() Unknown
ntdll.dll!00007fff2e0ece71() Unknown
Annotation 2019-08-08 170244

@Jewsh-S commented on GitHub (Aug 9, 2019): Sorry for the latest reply here. Yes I am okay doing this. I restored the file to what it should be on the latest branch (1e4e12507dda70af4c691442659ea0046a9fd98b) and ran a new build. To run a new build, I usually like to build from command prompt using .\tools\razzle.cmd; bcz Then I open OpenConsole.sln in VS and run for X64. When I restore the file to pre 0da13cdf2d5ba2081f12f85f6816546489d4918b I get a build succeed, but anything after that commit and I get the following: (same results with the latest build today). Sorry if this is all confusing. I will also post a screenshot VS at point of failure. See below for trace. > Microsoft.Toolkit.Win32.UI.XamlHost.dll!00007fff096f3879() Unknown Windows.UI.Xaml.dll!00007fff12a4704d() Unknown Windows.UI.Xaml.dll!00007fff1282398c() Unknown Windows.UI.Xaml.dll!00007fff12938589() Unknown Windows.UI.Xaml.dll!00007fff12932e7b() Unknown ntdll.dll!00007fff2e0a5031() Unknown ntdll.dll!00007fff2e0eaaa2() Unknown ntdll.dll!00007fff2e0ea94d() Unknown kernel32.dll!00007fff2c5acd8a() Unknown ucrtbased.dll!00007ffec8d0467a() Unknown ucrtbased.dll!00007ffec8d04629() Unknown ucrtbased.dll!00007ffec8d049a6() Unknown > WindowsTerminal.exe!__scrt_common_main_seh() Line 297 C++ WindowsTerminal.exe!__scrt_common_main() Line 331 C++ WindowsTerminal.exe!wWinMainCRTStartup() Line 17 C++ kernel32.dll!00007fff2c5a7bd4() Unknown ntdll.dll!00007fff2e0ece71() Unknown ![Annotation 2019-08-08 170244](https://user-images.githubusercontent.com/44556669/62743096-5cb97300-b9fe-11e9-99eb-86602b08ff2f.png) >
claunia commented 2026-01-30 23:17:05 +00:00
Author
Owner
Copy Link

@Jewsh-S commented on GitHub (Aug 9, 2019):

For a follow up. After that failure, I restored the 0da13cdf2d version of src/cascadia/TerminalConnection/ConhostConnection.cpp to the latest code and the build succeeded.

Annotation 2019-08-08 170819

Run latest Build with status shown above:

aa

@Jewsh-S commented on GitHub (Aug 9, 2019): For a follow up. After that failure, I restored the 0da13cdf2d5ba2081f12f85f6816546489d4918b version of src/cascadia/TerminalConnection/ConhostConnection.cpp to the latest code and the build succeeded. ![Annotation 2019-08-08 170819](https://user-images.githubusercontent.com/44556669/62743305-2cbe9f80-b9ff-11e9-9a32-101da31391b8.png) **Run latest Build with status shown above:** ![aa](https://user-images.githubusercontent.com/44556669/62743596-3dbbe080-ba00-11e9-8b29-b2ae2eca4e70.png)
claunia commented 2026-01-30 23:17:05 +00:00
Author
Owner
Copy Link

@Jewsh-S commented on GitHub (Aug 27, 2019):

I am closing this issue because it went away with commit ebcf8126dc

Today with the commit ebcf8126dc I am able to successfully build the application again without restoring the older version of the file.

@Jewsh-S commented on GitHub (Aug 27, 2019): I am closing this issue because it went away with commit ebcf8126dc0c212d18638f8650ea757fa150ba17 Today with the commit ebcf8126dc0c212d18638f8650ea757fa150ba17 I am able to successfully build the application again without restoring the older version of the file.
claunia commented 2026-01-30 23:17:05 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 27, 2019):

Thanks for following up!

@DHowett-MSFT commented on GitHub (Aug 27, 2019): Thanks for following up!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection Issue-Bug Needs-Attention Needs-Tag-Fix Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?