starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Redraw issue #3298

New Issue
Closed
opened 2026-01-30 23:18:02 +00:00 by claunia · 11 comments
claunia commented 2026-01-30 23:18:02 +00:00
Owner
Copy Link

Originally created by @SeanTAllen on GitHub (Aug 8, 2019).

I use fish shell that will display possible autocompletions. In terminal, it doesn't always draw the screen correctly. Here is a screenshot after completion where the last couple ghost characters were left over from the suggested completion. Note, this doesn't always happen. Normally everything is redrawn correctly.
Annotation 2019-08-08 120632

Currently using 0.3.2171.0

Originally created by @SeanTAllen on GitHub (Aug 8, 2019). I use `fish` shell that will display possible autocompletions. In terminal, it doesn't always draw the screen correctly. Here is a screenshot after completion where the last couple ghost characters were left over from the suggested completion. Note, this doesn't always happen. Normally everything is redrawn correctly. ![Annotation 2019-08-08 120632](https://user-images.githubusercontent.com/193596/62719126-4fd45980-b9d5-11e9-8a71-314070562396.png) Currently using 0.3.2171.0
claunia commented 2026-01-30 23:18:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 8, 2019):

I'd bet money that this is due to us incorrectly guessing the widths of the powerline chars. Looks like they're all being treated as double wide, but I'd imagine they're actually only 1 wide in the buffer.

Could you repro that scenario with the same font set in WSL via conhost.exe (not the Windows Terminal), and paste what it looks like?

@zadjii-msft commented on GitHub (Aug 8, 2019): I'd bet money that this is due to us incorrectly guessing the widths of the powerline chars. Looks like they're all being treated as double wide, but I'd imagine they're actually only 1 wide in the buffer. Could you repro that scenario with the same font set in WSL via conhost.exe (not the Windows Terminal), and paste what it looks like?
claunia commented 2026-01-30 23:18:03 +00:00
Author
Owner
Copy Link

@SeanTAllen commented on GitHub (Aug 8, 2019):

I can not reproduce via conhost.exe nor via the terminal in VSCode. It's purely a Windows Terminal issue.

However, here is a screenshot of what it looks like there (sans issue that doesn't happen there)...

Annotation 2019-08-08 130655

@SeanTAllen commented on GitHub (Aug 8, 2019): I can not reproduce via conhost.exe nor via the terminal in VSCode. It's purely a Windows Terminal issue. However, here is a screenshot of what it looks like there (sans issue that doesn't happen there)... ![Annotation 2019-08-08 130655](https://user-images.githubusercontent.com/193596/62722904-6da5bc80-b9dd-11e9-862e-f4b88d2305e4.png)
claunia commented 2026-01-30 23:18:03 +00:00
Author
Owner
Copy Link

@SeanTAllen commented on GitHub (Aug 8, 2019):

@zadjii-msft playing with this a bit more in windows terminal, it only appears to happen when the powerline has "git status" icons in it. The font that is used for that, doesn't display those symbols in conhost.

@SeanTAllen commented on GitHub (Aug 8, 2019): @zadjii-msft playing with this a bit more in windows terminal, it only appears to happen when the powerline has "git status" icons in it. The font that is used for that, doesn't display those symbols in conhost.
claunia commented 2026-01-30 23:18:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 8, 2019):

Could I get a screenshot with the up and down arrows in conhost? they look like maybe the one we're guessing is 2 wide instead of 1 wide:

These guys:
image

@zadjii-msft commented on GitHub (Aug 8, 2019): Could I get a screenshot with the up and down arrows in conhost? they look like maybe the one we're guessing is 2 wide instead of 1 wide: These guys: ![image](https://user-images.githubusercontent.com/18356694/62723058-65498380-b9d5-11e9-9ad6-15a48f3989f1.png)
claunia commented 2026-01-30 23:18:04 +00:00
Author
Owner
Copy Link

@SeanTAllen commented on GitHub (Aug 8, 2019):

Annotation 2019-08-08 131124

@SeanTAllen commented on GitHub (Aug 8, 2019): ![Annotation 2019-08-08 131124](https://user-images.githubusercontent.com/193596/62723186-0ccab400-b9de-11e9-98d1-15094a67562f.png)
claunia commented 2026-01-30 23:18:04 +00:00
Author
Owner
Copy Link

@SeanTAllen commented on GitHub (Aug 8, 2019):

And here they are in VSCode...

Annotation 2019-08-08 131204

@SeanTAllen commented on GitHub (Aug 8, 2019): And here they are in VSCode... ![Annotation 2019-08-08 131204](https://user-images.githubusercontent.com/193596/62723231-2b30af80-b9de-11e9-8669-56fc9c410bc9.png)
claunia commented 2026-01-30 23:18:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 8, 2019):

Yea that'll do it.

This is probably some combination of issues, #2066 might be the one that ends up fixing it.

@miniksa might also have thoughts on the character being rendered as 2 wide

@zadjii-msft commented on GitHub (Aug 8, 2019): Yea that'll do it. This is probably some combination of issues, #2066 might be the one that ends up fixing it. @miniksa might also have thoughts on the character being rendered as 2 wide
claunia commented 2026-01-30 23:18:04 +00:00
Author
Owner
Copy Link

@SeanTAllen commented on GitHub (Aug 8, 2019):

@zadjii-msft Let me know if you need anything else from me.

@SeanTAllen commented on GitHub (Aug 8, 2019): @zadjii-msft Let me know if you need anything else from me.
claunia commented 2026-01-30 23:18:05 +00:00
Author
Owner
Copy Link

@Dijir commented on GitHub (Aug 13, 2019):

On mine it is not rendering poweline characters correctly.

VSCode:

Windows Terminal:

@Dijir commented on GitHub (Aug 13, 2019): On mine it is not rendering poweline characters correctly. VSCode: ![](https://i.imgur.com/iyDH0Xr.png) Windows Terminal: ![](https://i.imgur.com/R909JiW.png)
claunia commented 2026-01-30 23:18:05 +00:00
Author
Owner
Copy Link

@ksawerykarwacki commented on GitHub (Aug 14, 2019):

@zadjii-msft I have some rare case. Characters have some strange random gaps (they are not always on the same spot) but it is like pixel or two wide not whole character.

{81FF00FF-FB28-4E40-98ED-C4E62F55346B}
@ksawerykarwacki commented on GitHub (Aug 14, 2019): @zadjii-msft I have some rare case. Characters have some strange random gaps (they are not always on the same spot) but it is like pixel or two wide not whole character. <img width="180" alt="{81FF00FF-FB28-4E40-98ED-C4E62F55346B}" src="https://user-images.githubusercontent.com/11694791/63029165-5caeec80-beb0-11e9-914e-d577679bb4aa.png">
claunia commented 2026-01-30 23:18:05 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 16, 2019):

This is almost certainly #633 #635, and will be helped by #2066.

@DHowett-MSFT commented on GitHub (Aug 16, 2019): This is almost certainly #633 #635, and will be helped by #2066.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Issue-Bug Product-Conpty Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?