starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

It is hard to see the pane divider in dark mode #3328

New Issue
Closed
opened 2026-01-30 23:18:42 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 23:18:42 +00:00
Owner
Copy Link

Originally created by @fpintos on GitHub (Aug 9, 2019).

Environment

Windows build number: 18362.239
Windows Terminal version (if applicable): 0.3.2142.0

Steps to reproduce

Open Windows Terminal in dark mode.
Add keybindings to split a tab into multiple panes. Ex:

            {
                "command": "splitHorizontal",
                "keys": [
                    "ctrl+shift+-"
                ]
            },
            {
                "command": "splitVertical",
                "keys": [
                    "ctrl+shift+|"
                ]
            },

Open a profile that has a dark background, like black or something close to that, ex, Campbell theme, where background is #0C0C0C.

Split the tab.

Expected behavior

To be able to easily distinguish the pane separator.

Actual behavior

In dark mode the pane separator is hard to see due to low contrast with surrounding background. Example:
image

In comparison, in light mode the separator is very visible:
image

Ideally, the color of the separator should take into consideration the surrounding background in order to show up with enough contrast to be visible in any combination.

Originally created by @fpintos on GitHub (Aug 9, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 18362.239 Windows Terminal version (if applicable): 0.3.2142.0 ``` # Steps to reproduce Open Windows Terminal in dark mode. Add keybindings to split a tab into multiple panes. Ex: ```json { "command": "splitHorizontal", "keys": [ "ctrl+shift+-" ] }, { "command": "splitVertical", "keys": [ "ctrl+shift+|" ] }, ``` Open a profile that has a dark background, like black or something close to that, ex, Campbell theme, where background is #0C0C0C. Split the tab. # Expected behavior To be able to easily distinguish the pane separator. # Actual behavior In dark mode the pane separator is hard to see due to low contrast with surrounding background. Example: ![image](https://user-images.githubusercontent.com/4239171/62805059-b45dea00-baa3-11e9-80c4-e97ffaebcb5f.png) In comparison, in light mode the separator is very visible: ![image](https://user-images.githubusercontent.com/4239171/62805092-d3f51280-baa3-11e9-9d73-756e141ae1fe.png) Ideally, the color of the separator should take into consideration the surrounding background in order to show up with enough contrast to be visible in any combination.
claunia added the Resolution-Duplicate label 2026-01-30 23:18:42 +00:00
claunia commented 2026-01-30 23:18:42 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Aug 9, 2019):

Make it color configurable. Because I'd like red for dark mode but somebody might want blue, and another person green, and so on.

@WSLUser commented on GitHub (Aug 9, 2019): Make it color configurable. Because I'd like red for dark mode but somebody might want blue, and another person green, and so on.
claunia commented 2026-01-30 23:18:43 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 9, 2019):

I am not of the opinion that we need a configuration option for every pixel that appears on the screen. It's a UI element: when we have a configurable UI, it'll "follow". 😄

@DHowett-MSFT commented on GitHub (Aug 9, 2019): I am not of the opinion that we need a configuration option for every pixel that appears on the screen. It's a UI element: when we have a configurable UI, it'll "follow". :smile:
claunia commented 2026-01-30 23:18:43 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Aug 9, 2019):

Ha yeah I don't believe there should be a config option for every pixel but with the configurable UI, I'd like control over each of the UI elements if possible. Probably can just make it match light mode for now as a default (though I'd appreciate you more if you made it red by default).

@WSLUser commented on GitHub (Aug 9, 2019): Ha yeah I don't believe there should be a config option for every pixel but with the configurable UI, I'd like control over each of the UI elements if possible. Probably can just make it match light mode for now as a default (though I'd appreciate you more if you made it red by default).
claunia commented 2026-01-30 23:18:43 +00:00
Author
Owner
Copy Link

@jolsen71 commented on GitHub (Aug 14, 2019):

In related manner, it'd be nice to have a visual border between the tabs, too. At least for me I can't see any border at all.
image
In distant (unrelated?) topic, I can barely tell which tab is active.

@jolsen71 commented on GitHub (Aug 14, 2019): In related manner, it'd be nice to have a visual border between the tabs, too. At least for me I can't see any border at all. ![image](https://user-images.githubusercontent.com/6641548/63056931-ba423980-beae-11e9-8993-3d818c1d2804.png) In distant (unrelated?) topic, I can barely tell which tab is active.
claunia commented 2026-01-30 23:18:43 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 16, 2019):

The tab separator issue was already fixed upstream; we just need to ingest a new version of the package.
I'm going to close this out in favor of #1000, the epic for panes.

@DHowett-MSFT commented on GitHub (Aug 16, 2019): The tab separator issue was already fixed upstream; we just need to ingest a new version of the package. I'm going to close this out in favor of #1000, the epic for panes.
claunia commented 2026-01-30 23:18:44 +00:00
Author
Owner
Copy Link

@dlukes commented on GitHub (Mar 25, 2020):

I'd like control over each of the UI elements if possible

@WSLUser Currently, the color of the separator in dark mode seems to match your highlight color setting under the system-wide Themes and related settings (find that via the Start menu), so if you want to customize it, that's the way to go :)

@dlukes commented on GitHub (Mar 25, 2020): > I'd like control over each of the UI elements if possible @WSLUser Currently, the color of the separator in dark mode seems to match your highlight color setting under the system-wide *Themes and related settings* (find that via the Start menu), so if you want to customize it, that's the way to go :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?