starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Adding multiple elements to a "keys" list under "keybindings" causes the entire binding to be discarded #3346

New Issue
Closed
opened 2026-01-30 23:19:13 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 23:19:13 +00:00
Owner
Copy Link

Originally created by @pickscrape on GitHub (Aug 10, 2019).

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.267]
Windows Terminal version (if applicable): 0.3.2171.0

Any other software?

Steps to reproduce

  1. Edit config.
  2. For any keybinding, add an additional key definition to the "keys" list.
  3. Close and re-open Terminal
  4. See that the entire command has been removed from the "keybindings" section of the config

In my case, I was trying to add shift+insert as an additional paste keybinding. At first, I though the problem was an incorrect key specification on my part, but using "shift+insert" as the sole keybinding worked fine.

Expected behavior

At the very least, I would expect both the keybinding element, and the first item in the "keys" list, to be maintained.

Ideally, all keybindings in the list would work to activate the function (assuming no conflicts with keybindings in other functions).

Actual behavior

The entire keybinding element is removed

Originally created by @pickscrape on GitHub (Aug 10, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.267] Windows Terminal version (if applicable): 0.3.2171.0 Any other software? ``` # Steps to reproduce 1. Edit config. 1. For any keybinding, add an additional key definition to the "keys" list. 1. Close and re-open Terminal 1. See that the entire command has been removed from the "keybindings" section of the config In my case, I was trying to add shift+insert as an additional paste keybinding. At first, I though the problem was an incorrect key specification on my part, but using "shift+insert" as the sole keybinding worked fine. # Expected behavior At the very least, I would expect both the keybinding element, and the first item in the "keys" list, to be maintained. Ideally, all keybindings in the list would work to activate the function (assuming no conflicts with keybindings in other functions). # Actual behavior The entire keybinding element is removed
claunia added the Issue-QuestionNeeds-TriageArea-SettingsResolution-Answered labels 2026-01-30 23:19:13 +00:00
claunia commented 2026-01-30 23:19:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 10, 2019):

So this is pretty interesting. The right way to add multiple bindings for the same event is to duplicate the entire binding -- that is:

{command: "x", keys: [ "y" ]},
{command: "x", keys: [ "z" ]},

multiple keys in the keys array are actually for key chording, like "Ctrl+B followed by E". That's not actually supported today, it's just aspirational.

@DHowett-MSFT commented on GitHub (Aug 10, 2019): So this is pretty interesting. The right way to add multiple bindings for the same event is to _duplicate the entire binding_ -- that is: ``` {command: "x", keys: [ "y" ]}, {command: "x", keys: [ "z" ]}, ``` multiple keys in the `keys` array are actually for key _chording_, like "<kbd>Ctrl+B</kbd> followed by <kbd>E</kbd>". That's not _actually_ supported today, it's just aspirational.
claunia commented 2026-01-30 23:19:15 +00:00
Author
Owner
Copy Link

@pickscrape commented on GitHub (Aug 10, 2019):

Oh! Well, that makes sense now that I know it, but it wasn't clear to me at all.

I'm not sure where I should have gone to find that out myself?

@pickscrape commented on GitHub (Aug 10, 2019): Oh! Well, that makes sense now that I know it, but it wasn't clear to me at all. I'm not sure where I should have gone to find that out myself?
claunia commented 2026-01-30 23:19:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 12, 2019):

We could definitely document this better. It'll work a lot better once #1334 is done, though. 😄 Sorry about that.

@DHowett-MSFT commented on GitHub (Aug 12, 2019): We could definitely document this better. It'll work a lot better once #1334 is done, though. :smile: Sorry about that.
claunia commented 2026-01-30 23:19:15 +00:00
Author
Owner
Copy Link

@0xabu commented on GitHub (Sep 19, 2019):

I just came here to note that I made the same assumption/mistake at the original submitter. I've never encountered a terminal that used chorded key bindings before (surely there will never be so many actions in a terminal?), so didn't even consider the possibility.

Given that multiple bindings are effectively broken at the moment anyway (#2389) might this design choice be worth revisiting?

@0xabu commented on GitHub (Sep 19, 2019): I just came here to note that I made the same assumption/mistake at the original submitter. I've never encountered a terminal that used chorded key bindings before (surely there will never be so many actions in a terminal?), so didn't even consider the possibility. Given that multiple bindings are effectively broken at the moment anyway (#2389) might this design choice be worth revisiting?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Triage Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?