starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ConPTY does not translate arrow keys with +ENHANCED_KEY in their modifiers #3364

New Issue
Closed
opened 2026-01-30 23:19:35 +00:00 by claunia · 11 comments
claunia commented 2026-01-30 23:19:35 +00:00
Owner
Copy Link

Originally created by @SummerGift on GitHub (Aug 12, 2019).

Originally assigned to: @carlos-zamora on GitHub.

Today I updated Windows to 1903 and found that a python program I had written earlier ran incorrectly.

The brief test code is as follows:

import msvcrt
ch1 = msvcrt.getch()
ch2 = msvcrt.getch()
print(ch1)
print(ch2)

When I run the above code in native powershell, press ← key when collecting characters, and it will print b'\xe0' B 'K', and the same code running in the terminal returns b'\x00' b'K'.
This problem didn't appear in the last version of Windows (18.xx).

Steps to Reproduce:

  1. Run this code on the powershell terminal of vscode using Python3
  2. press ← key，record print information
  3. Run this code directly from your powershell on Windows using Python3
  4. press ← key，record print information
  5. Look at different outputs

A related issue on vscode：

https://github.com/microsoft/vscode/issues/78682

Thank you for your attention.

Originally created by @SummerGift on GitHub (Aug 12, 2019). Originally assigned to: @carlos-zamora on GitHub. Today I updated Windows to 1903 and found that a python program I had written earlier ran incorrectly. The brief test code is as follows: ``` import msvcrt ch1 = msvcrt.getch() ch2 = msvcrt.getch() print(ch1) print(ch2) ``` When I run the above code in native powershell, press ← key when collecting characters, and it will print `b'\xe0' B 'K'`, and the same code running in the terminal returns `b'\x00' b'K'`. This problem didn't appear in the last version of Windows (18.xx). - OS Version: windows 10 1903 - [terminal version](https://www.microsoft.com/en-us/p/windows-terminal-preview/9n0dx20hk701?activetab=pivot:overviewtab) : preview Steps to Reproduce: 1. Run this code on the powershell terminal of vscode using Python3 2. press ← key，record print information 3. Run this code directly from your powershell on Windows using Python3 4. press ← key，record print information 5. Look at different outputs A related issue on vscode： https://github.com/microsoft/vscode/issues/78682 Thank you for your attention.
claunia commented 2026-01-30 23:19:36 +00:00
Author
Owner
Copy Link

@SummerGift commented on GitHub (Aug 19, 2019):

Any help?

@SummerGift commented on GitHub (Aug 19, 2019): Any help?
claunia commented 2026-01-30 23:19:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 19, 2019):

We believe this is a bug, but we're not really sure what the root cause is. Presumably something about how ConPTY builds INPUT_RECORDs compared to how we build them from window input directly.

We're also very confused that ch1 in the above sample is b'\xe0' b'K' - we really didn't expect that. So we just need someone to really debug into this.

@zadjii-msft commented on GitHub (Aug 19, 2019): We believe this is a bug, but we're not really sure what the root cause is. Presumably something about how ConPTY builds `INPUT_RECORD`s compared to how we build them from window input directly. We're also _very_ confused that `ch1` in the above sample is `b'\xe0' b'K'` - we _really_ didn't expect that. So we just need someone to really debug into this.
claunia commented 2026-01-30 23:19:36 +00:00
Author
Owner
Copy Link

@SummerGift commented on GitHub (Sep 2, 2019):

Before the 1903 version of Windows, the return value was b'\xe0' b'K', which became b'\x00' b'K' when upgraded to 1903, causing some programs to fail.

@SummerGift commented on GitHub (Sep 2, 2019): Before the 1903 version of Windows, the return value was b'\xe0' b'K', which became b'\x00' b'K' when upgraded to 1903, causing some programs to fail.
claunia commented 2026-01-30 23:19:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 1, 2019):

Eureka!

Under normal circumstances:

  • ↓ wch:0x0000 '\0' mod:EnhancedKey (0x00000100) repeat:0x0001 vk:0x0025 vsc:0x004b

Under ConPTY:

  • ↓ wch:0x0000 '\0' mod:None (0x00000000) repeat:0x0001 vk:0x0025 vsc:0x004b

Critical here is mod:EnhancedKey. ConPTY isn't setting it. I'm not sure how it could know to set it, because we usually derive its value from the Win32 window proc...
ConPTY only sets it if there's a modifier on the arrow key.

The documentation on ENHANCED_KEY says:

Enhanced keys for the IBM® 101- and 102-key keyboards are the INS, DEL, HOME, END, PAGE UP, PAGE DOWN, and direction keys in the clusters to the left of the keypad; and the divide (/) and ENTER keys in the keypad.

@DHowett-MSFT commented on GitHub (Oct 1, 2019): Eureka! Under normal circumstances: * `↓ wch:0x0000 '\0' mod:EnhancedKey (0x00000100) repeat:0x0001 vk:0x0025 vsc:0x004b` Under ConPTY: * `↓ wch:0x0000 '\0' mod:None (0x00000000) repeat:0x0001 vk:0x0025 vsc:0x004b` Critical here is `mod:EnhancedKey`. ConPTY isn't setting it. I'm not sure how it could know _to_ set it, because we usually derive its value from the Win32 window proc... ConPTY only sets it if there's a modifier _on_ the arrow key. The [documentation](https://docs.microsoft.com/en-us/windows/console/key-event-record-str) on `ENHANCED_KEY` says: > Enhanced keys for the IBM® 101- and 102-key keyboards are the INS, DEL, HOME, END, PAGE UP, PAGE DOWN, and direction keys in the clusters to the left of the keypad; and the divide (/) and ENTER keys in the keypad.
claunia commented 2026-01-30 23:19:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 1, 2019):

And now that we have a root cause, I'm finally renaming this issue.

@DHowett-MSFT commented on GitHub (Oct 1, 2019): And now that we have a root cause, I'm finally renaming this issue.
claunia commented 2026-01-30 23:19:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 1, 2019):

Yanking the triage tag after a discussion with @carlos-zamora and @zadjii-msft. Carlos is down to look at this 😄

@DHowett-MSFT commented on GitHub (Oct 1, 2019): Yanking the triage tag after a discussion with @carlos-zamora and @zadjii-msft. Carlos is down to look at this :smile:
claunia commented 2026-01-30 23:19:37 +00:00
Author
Owner
Copy Link

@wmcbrine commented on GitHub (Nov 3, 2019):

This also prevents PDCurses from recognizing the cursor keys, as I just discovered.

@wmcbrine commented on GitHub (Nov 3, 2019): This also prevents PDCurses from recognizing the cursor keys, as I just discovered.
claunia commented 2026-01-30 23:19:37 +00:00
Author
Owner
Copy Link

@SummerGift commented on GitHub (Nov 4, 2019):

This also prevents PDCurses from recognizing the cursor keys, as I just discovered.

So, the program written before runs unnormal.

@SummerGift commented on GitHub (Nov 4, 2019): > This also prevents PDCurses from recognizing the cursor keys, as I just discovered. So, the program written before runs unnormal.
claunia commented 2026-01-30 23:19:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5021, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5021, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
claunia commented 2026-01-30 23:19:38 +00:00
Author
Owner
Copy Link

@thomthom commented on GitHub (Apr 22, 2020):

Thank you! I can finally get rid of cmder now and switch to Terminal full time! 🎉

@thomthom commented on GitHub (Apr 22, 2020): Thank you! I can finally get rid of `cmder` now and switch to Terminal full time! 🎉
claunia commented 2026-01-30 23:19:38 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 22, 2020):

Great!

@DHowett-MSFT commented on GitHub (Apr 22, 2020): Great!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Issue-Bug Priority-2 Product-Conpty Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?