starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash when attempting to split pane with insufficient space available #3371

New Issue
Closed
opened 2026-01-30 23:19:47 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 23:19:47 +00:00
Owner
Copy Link

Originally created by @richardszalay on GitHub (Aug 12, 2019).

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.175]
Windows Terminal version (if applicable):0.3.2171.0

Steps to reproduce

  1. Map a key binding to splitHorizontal
  2. Invoke the splitHorizontal key binding beyond the point where space is available for the split (~6-7 times)

NOTE: It also happens when splitting vertically but it appears to allow more before crashing.

Expected behavior

Worth discussing, but I'm guessing it would simply reject the command and perform a system beep (or some other indication of the failure)

Actual behavior

Application crash

Originally created by @richardszalay on GitHub (Aug 12, 2019). # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.175] Windows Terminal version (if applicable):0.3.2171.0 ``` # Steps to reproduce 1. Map a key binding to `splitHorizontal` 2. Invoke the `splitHorizontal` key binding beyond the point where space is available for the split (~6-7 times) NOTE: It also happens when splitting vertically but it appears to allow more before crashing. # Expected behavior Worth discussing, but I'm guessing it would simply reject the command and perform a system beep (or some other indication of the failure) # Actual behavior Application crash
claunia commented 2026-01-30 23:19:48 +00:00
Author
Owner
Copy Link

@richardszalay commented on GitHub (Aug 16, 2019):

I've confirmed that the root cause of the error is that splitting small panes results in a width/height of 0, which causes the DxRenderer to fail when creating the device resources.

I'd like to PR this if you don't mind. Here's my proposed implementation, but I'm happy to PR it as a spec if you think the issue warrants it:

App::_SplitPane will call focusedTab->CanAddHorizontalSplit/CanAddHorizontalSplit before it initializes the TermControl to avoid having to deal with the cleanup. If a split cannot occur, it will simply return. Question Should we beep or something here?

I'll follow the same naming conventions that already exist, so: Tab::CanAddHorizontalSplit -> Pane::CanSplitHorizontal ->Pane::_CanSplit. The public pane methods will handle leaf/child the same as the current Split methods.

_CanSplit will reuse existing logic to determine the split, including _root.GetActualWidth/height, Pane::_GetMinSize, and the Half constant.

@richardszalay commented on GitHub (Aug 16, 2019): I've confirmed that the root cause of the error is that splitting small panes results in a width/height of 0, which causes the DxRenderer to fail when creating the device resources. I'd like to PR this if you don't mind. Here's my proposed implementation, but I'm happy to PR it as a spec if you think the issue warrants it: `App::_SplitPane` will call `focusedTab->CanAddHorizontalSplit/CanAddHorizontalSplit` _before_ it initializes the `TermControl` to avoid having to deal with the cleanup. If a split cannot occur, it will simply return. **Question** Should we beep or something here? I'll follow the same naming conventions that already exist, so: `Tab::CanAddHorizontalSplit -> Pane::CanSplitHorizontal ->Pane::_CanSplit`. The public pane methods will handle leaf/child the same as the current Split methods. `_CanSplit` will reuse existing logic to determine the split, including `_root.GetActualWidth/height`, `Pane::_GetMinSize`, and the `Half` constant.
claunia commented 2026-01-30 23:19:48 +00:00
Author
Owner
Copy Link

@richardszalay commented on GitHub (Aug 16, 2019):

If you're happy with my proposed design and don't think it needs a beep, I've submitted a PR.

@richardszalay commented on GitHub (Aug 16, 2019): If you're happy with my proposed design and don't think it needs a beep, I've submitted a PR.
claunia commented 2026-01-30 23:19:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 16, 2019):

Yea I definitely don't think we need a beep currently. We don't beep for anything else quite yet, so we could always add a (optional) beep here later when we add beeps to the rest of the app.

Good work with the PR!

@zadjii-msft commented on GitHub (Aug 16, 2019): Yea I definitely don't think we need a beep currently. We don't beep for _anything_ else quite yet, so we could always add a (optional) beep here later when we add beeps to the rest of the app. Good work with the PR!
claunia commented 2026-01-30 23:19:48 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 27, 2019):

:tada:This issue was addressed in #2450, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 27, 2019): :tada:This issue was addressed in #2450, which has now been successfully released as `Windows Terminal Preview v0.4.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.4.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?