starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Settings file being reformatted when settings are changed by the program #3389

New Issue
Closed
opened 2026-01-30 23:20:09 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:20:09 +00:00
Owner
Copy Link

Originally created by @giggio on GitHub (Aug 12, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: Microsoft Windows NT 10.0.18362.0                                                                                                                                                                                     

Windows Terminal version: latest from the master branch

Any other software?
N/A

Steps to reproduce

With the terminal closed, do anything that trigger a json settings file rewrite, for example, add any setting to the settings json file that is not on the schema (or is invalid), for example:

{
    "Foo": 1,
    "globals" :
    {

Then, open the terminal

Expected behavior

Terminal warns me somehow, or comments out the invalid setting. But does not, ever, reformat the file.

Actual behavior

The settings file is rewritten and reformatted, and, worse of all, an annoying trailing space is added to the end of every json key. See image bellow:

CodeSettingsFile

Originally created by @giggio on GitHub (Aug 12, 2019). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: Microsoft Windows NT 10.0.18362.0 Windows Terminal version: latest from the master branch Any other software? N/A ``` # Steps to reproduce With the terminal closed, do anything that trigger a json settings file rewrite, for example, add any setting to the settings json file that is not on the schema (or is invalid), for example: ````json { "Foo": 1, "globals" : { ```` Then, open the terminal # Expected behavior Terminal warns me somehow, or comments out the invalid setting. But does not, ever, reformat the file. # Actual behavior The settings file is rewritten and reformatted, and, worse of all, an annoying trailing space is added to the end of every json key. See image bellow: ![CodeSettingsFile](https://user-images.githubusercontent.com/334958/62889785-6dc4f580-bd18-11e9-8b9a-dceb89684bfe.gif)
claunia added the Resolution-Fix-CommittedArea-SettingsIssue-BugProduct-Terminal labels 2026-01-30 23:20:09 +00:00
claunia commented 2026-01-30 23:20:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 12, 2019):

Getting rid of this behavior is a critical (and already called out!) part of the work specified in #1258. 😄

@DHowett-MSFT commented on GitHub (Aug 12, 2019): Getting rid of this behavior is a critical (and already called out!) part of the work specified in #1258. :smile:
claunia commented 2026-01-30 23:20:10 +00:00
Author
Owner
Copy Link

@egmontkob commented on GitHub (Aug 12, 2019):

The Actual vs. Expected behavior sections are swapped, aren't they?

@egmontkob commented on GitHub (Aug 12, 2019): The Actual vs. Expected behavior sections are swapped, aren't they?
claunia commented 2026-01-30 23:20:11 +00:00
Author
Owner
Copy Link

@giggio commented on GitHub (Aug 13, 2019):

Yes, fixed, thanks.

@giggio commented on GitHub (Aug 13, 2019): Yes, fixed, thanks.
claunia commented 2026-01-30 23:20:11 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 23, 2019):

@zadjii-msft got rid of settings reserialization recently. 😄

@DHowett-MSFT commented on GitHub (Aug 23, 2019): @zadjii-msft got rid of settings reserialization recently. :smile:
claunia commented 2026-01-30 23:20:11 +00:00
Author
Owner
Copy Link

@giggio commented on GitHub (Aug 27, 2019):

Awesome, I just confirmed it with my latest private build. Tks!

@giggio commented on GitHub (Aug 27, 2019): Awesome, I just confirmed it with my latest private build. Tks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?