Terminal crashes if I specify an invalid fontFace #3677

Closed
opened 2026-01-30 23:27:06 +00:00 by claunia · 4 comments
Owner

Originally created by @jtnord on GitHub (Aug 30, 2019).

Environment

Windows build number: 10.0.18362.295
Windows Terminal version (if applicable): 0.3.2171.0


Any other software?

 Clink v0.4.9 [git:2fd2c2]  (http://mridgers.github.io/clink)

Steps to reproduce

open a cmd tab
edit the settings and change fontFace for the cmd profile to something invalid (apending "ZZZ" for example)

Expected behavior

terminal uses a default font and does not crash

Actual behaviour

terminal terminates

This would sound like a perfect dupe of #550 only I am running 0.3.2171.0 and that was "fixed" in 0.3.2142.0
Terminal does not terminate if you start cmd.exe without autorun extensions (clink) with the /D flag.

If you have powershell tabs open terminal still terminates and you loose work (which is why I beleive this is a terminal bug and not a clink one)

Originally created by @jtnord on GitHub (Aug 30, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18362.295 Windows Terminal version (if applicable): 0.3.2171.0 Any other software? Clink v0.4.9 [git:2fd2c2] (http://mridgers.github.io/clink) ``` # Steps to reproduce open a cmd tab edit the settings and change fontFace for the cmd profile to something invalid (apending "ZZZ" for example) # Expected behavior terminal uses a default font and does not crash # Actual behaviour terminal terminates This would sound like a perfect dupe of #550 only I am running `0.3.2171.0` and that was "fixed" in `0.3.2142.0` Terminal does not terminate if you start cmd.exe without autorun extensions (clink) with the `/D` flag. If you have powershell tabs open terminal still terminates and you loose work (which is why I beleive this is a terminal bug and not a clink one)
Author
Owner

@DHowett-MSFT commented on GitHub (Sep 3, 2019):

Interesting. I can't repro this, as you expected, without clink. What does clink do on startup that cmd doesn't do? Does it print something? Terminal is isolated from the shell by a text stream, so it's only text and escape sequences that could be coming from clink that'd cause us to crash.

@DHowett-MSFT commented on GitHub (Sep 3, 2019): Interesting. I can't repro this, as you expected, without clink. What does clink do on startup that cmd doesn't do? Does it print something? Terminal is isolated from the shell by a text stream, so it's only text and escape sequences that could be coming from clink that'd cause us to crash.
Author
Owner

@ghost commented on GitHub (Sep 5, 2019):

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost commented on GitHub (Sep 5, 2019): Hi there!<br><br>Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?<br><br>Thanks!<br><br>![image](https://user-images.githubusercontent.com/18221333/62478757-b69d0d00-b760-11e9-9626-1fa33c91e7c5.png) ![image](https://user-images.githubusercontent.com/18221333/62478649-6de55400-b760-11e9-806e-5aab7e085a9f.png)
Author
Owner

@ghost commented on GitHub (Sep 9, 2019):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Sep 9, 2019): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Author
Owner

@ghost commented on GitHub (Sep 17, 2019):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Sep 17, 2019): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3677