starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Use color scheme 'name' as key (vs an index number) #3712

New Issue
Closed
opened 2026-01-30 23:28:07 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 23:28:07 +00:00
Owner
Copy Link

Originally created by @mikemaccana on GitHub (Sep 2, 2019).

Currently color schemes are referred to by their name attribute:

"colorScheme": "Monokai Soda",

But they're stored in an array, ie keyed by index number. The actual key used - name - is mixed in with the colors. This makes the file slightly harder to parse if you're hand editing, and is also odd - you don't expect the name to be one of the colors.

Instead of:

  "schemes": [
    {
      "background": "#1A1A1A",
      "black": "#CCCCCC",
      "blue": "#9D65FF",
      "brightBlack": "#625E4C",
      "brightBlue": "#9D65FF",
      "brightCyan": "#58D1EB",
      "brightGreen": "#98E024",
      "brightPurple": "#F4005F",
      "brightRed": "#F4005F",
      "brightWhite": "#F6F6EF",
      "brightYellow": "#E0D561",
      "cyan": "#58D1EB",
      "foreground": "#C4C5B5",
      "green": "#98E024",
      "name": "Monokai Soda",
      "purple": "#F4005F",
      "red": "#F4005F",
      "white": "#C4C5B5",
      "yellow": "#FA8419"
    }
  ]

It would be better to do:

  "schemes": {
    "Monokai Soda": {
      "background": "#1A1A1A",
      "black": "#CCCCCC",
      "blue": "#9D65FF",
      "brightBlack": "#625E4C",
      "brightBlue": "#9D65FF",
      "brightCyan": "#58D1EB",
      "brightGreen": "#98E024",
      "brightPurple": "#F4005F",
      "brightRed": "#F4005F",
      "brightWhite": "#F6F6EF",
      "brightYellow": "#E0D561",
      "cyan": "#58D1EB",
      "foreground": "#C4C5B5",
      "green": "#98E024",
      "purple": "#F4005F",
      "red": "#F4005F",
      "white": "#C4C5B5",
      "yellow": "#FA8419"
    }
  }
Originally created by @mikemaccana on GitHub (Sep 2, 2019). Currently color schemes are referred to by their `name` attribute: ```"colorScheme": "Monokai Soda",``` But they're stored in an array, ie keyed by index number. The actual key used - `name` - is mixed in with the colors. This makes the file slightly harder to parse if you're hand editing, and is also odd - you don't expect the name to be one of the colors. Instead of: ``` "schemes": [ { "background": "#1A1A1A", "black": "#CCCCCC", "blue": "#9D65FF", "brightBlack": "#625E4C", "brightBlue": "#9D65FF", "brightCyan": "#58D1EB", "brightGreen": "#98E024", "brightPurple": "#F4005F", "brightRed": "#F4005F", "brightWhite": "#F6F6EF", "brightYellow": "#E0D561", "cyan": "#58D1EB", "foreground": "#C4C5B5", "green": "#98E024", "name": "Monokai Soda", "purple": "#F4005F", "red": "#F4005F", "white": "#C4C5B5", "yellow": "#FA8419" } ] ``` It would be better to do: ``` "schemes": { "Monokai Soda": { "background": "#1A1A1A", "black": "#CCCCCC", "blue": "#9D65FF", "brightBlack": "#625E4C", "brightBlue": "#9D65FF", "brightCyan": "#58D1EB", "brightGreen": "#98E024", "brightPurple": "#F4005F", "brightRed": "#F4005F", "brightWhite": "#F6F6EF", "brightYellow": "#E0D561", "cyan": "#58D1EB", "foreground": "#C4C5B5", "green": "#98E024", "purple": "#F4005F", "red": "#F4005F", "white": "#C4C5B5", "yellow": "#FA8419" } } ```
claunia commented 2026-01-30 23:28:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 9, 2019):

So, we just discussed this right now.

There are a couple issues here. If we use the name as the primary key for the scheme, and don't include the name property in the scheme object, then the object can't really exist independently. The scheme object is now dependent upon being in a map of other colors.

Also, what happens if we have more sources for settings than just the singular profiles.json file? What if we have some WindowsTerminal/schemes folder with a bunch of scheme files? These might conflict, they might not have the name as the key for the object.

I'm not really sure what we get from switching to this schema, esp. when #2515 will both not reorder settings, and add a defaults.json where the name is the first key.

@zadjii-msft commented on GitHub (Sep 9, 2019): So, we just discussed this right now. There are a couple issues here. If we use the `name` as the primary key for the scheme, and _don't_ include the `name` property in the scheme object, then the object can't really exist independently. The scheme object is now dependent upon being in a map of other colors. Also, what happens if we have more sources for settings than just the singular `profiles.json` file? What if we have some `WindowsTerminal/schemes` folder with a bunch of scheme files? These might conflict, they might not have the name as the key for the object. I'm not really sure what we get from switching to this schema, esp. when #2515 will both _not_ reorder settings, and add a `defaults.json` where the name _is_ the first key.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Triage Product-Terminal Resolution-Won't-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?