starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Audit] Remove suppression on CodepointWidthDetector #3759

New Issue
Open
opened 2026-01-30 23:29:33 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 23:29:33 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Sep 5, 2019).

While turning on the audit mode, I ran into a condundrum with the CodepointWidthDetector that I didn't really want to dig into at the moment.

The warning is complaining that we have a global object with complex initialization. That is true. But there's some decisions to be made here that equaled "not-a-quick-fix".

The CodepointWidthDetector is a class designed to have multiple instances if need be.

However, for the most part, it is used in a single-instance manner inside conhost and wt.

The class GlyphWidth.cpp is mostly a wrapper around CodepointWidthDetector to turn it into a singleton that can be accessed by C-style methods in the global namespace.

The decisions here are really around...

Should CodepointWidthDetector just be a singleton itself and only hand out a copy of itself on Instance()? I know that's fine for conhost, but I haven't fully considered it for wt yet.

If we get rid of the C-style global namespace methods (by removing the entire GlyphWidth class), will that cause a kerfluffle throughout the conhost codebase (and maybe wt too) because there are a bunch of places that gratuitously grab the global state since it was never encapsulated before?

Anything else I didn't have time to fully consider here?

Originally created by @miniksa on GitHub (Sep 5, 2019). While turning on the audit mode, I ran into a condundrum with the `CodepointWidthDetector` that I didn't really want to dig into at the moment. The warning is complaining that we have a global object with complex initialization. That is true. But there's some decisions to be made here that equaled "not-a-quick-fix". The `CodepointWidthDetector` is a class designed to have multiple instances if need be. However, for the most part, it is used in a single-instance manner inside `conhost` and `wt`. The class `GlyphWidth.cpp` is mostly a wrapper around `CodepointWidthDetector` to turn it into a singleton that can be accessed by C-style methods in the global namespace. The decisions here are really around... Should `CodepointWidthDetector` just be a singleton itself and only hand out a copy of itself on `Instance()`? I know that's fine for `conhost`, but I haven't fully considered it for `wt` yet. If we get rid of the C-style global namespace methods (by removing the entire `GlyphWidth` class), will that cause a kerfluffle throughout the `conhost` codebase (and maybe `wt` too) because there are a bunch of places that gratuitously grab the global state since it was never encapsulated before? Anything else I didn't have time to fully consider here?
claunia commented 2026-01-30 23:29:34 +00:00
Author
Owner
Copy Link

@0xabu commented on GitHub (Sep 20, 2019):

See also #2375 … still hitting this crash at least once per week.

@0xabu commented on GitHub (Sep 20, 2019): See also #2375 … still hitting this crash at least once per week.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Output Issue-Task Product-Conhost Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3759
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?