starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

line height improperly calculated for scaling other than 100% #3903

New Issue
Closed
opened 2026-01-30 23:32:56 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 23:32:56 +00:00
Owner
Copy Link

Originally created by @ivanov on GitHub (Sep 16, 2019).

Environment

Microsoft Windows [Version 10.0.18362.295]
Windows Terminal (Preview)
Version: 0.4.2382.0

Steps to reproduce

Switch the "Change the size of text, apps, and other items" to something other than 100%
Open up Terminal and colorize multiple contiguous lines on the screen
(For me, I'm running WSL and run vim followed by :color blue)

Expected behavior

There should not be any gaps between the characters.

Here's the terminal on a 2560x1440 resolution monitor (Landscape) at 100% scale setting
image

Actual behavior

On 125% zoom, the same window now looks like this (tiny black horizontal marks between what should be contiguous lines of text all colored blue).

image

At 150% scale, we have a similar issue, though now instead of every line being affected, every other line has the horizontal artifact.
image

175%, and 225% zoom seem to have the same artifact line pattern as 125%

200% zoom has no artifact.

This looks similar to the artifact reported by @shanselman in https://github.com/microsoft/terminal/issues/455#issuecomment-518455051, but the issue I see is present independent of the fontFace setting (i see it both with fontFace set to Fira Code, and with fontFace setting removed thus falling back to the default fontFace).

Note: I initially came across this while using multiple monitors, and the artifact presented itself when dragging between two monitors. It turns out that the Scale setting is on a per-monitor basis, so if anyone working on a fix has multiple monitors, they can test several scale settings in parallel, as dragging the window between monitors will dynamically apply the scaling to the window.

Originally created by @ivanov on GitHub (Sep 16, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Environment ```none Microsoft Windows [Version 10.0.18362.295] Windows Terminal (Preview) Version: 0.4.2382.0 ``` # Steps to reproduce Switch the "Change the size of text, apps, and other items" to something other than 100% Open up Terminal and colorize multiple contiguous lines on the screen (For me, I'm running WSL and run `vim` followed by `:color blue`) # Expected behavior There should not be any gaps between the characters. Here's the terminal on a 2560x1440 resolution monitor (Landscape) at 100% scale setting ![image](https://user-images.githubusercontent.com/118211/64994589-e0803e00-d88d-11e9-93d0-47979b062768.png) # Actual behavior On 125% zoom, the same window now looks like this (tiny black horizontal marks between what should be contiguous lines of text all colored blue). ![image](https://user-images.githubusercontent.com/118211/64995002-f5110600-d88e-11e9-9477-0e168c96b404.png) At 150% scale, we have a similar issue, though now instead of every line being affected, every other line has the horizontal artifact. ![image](https://user-images.githubusercontent.com/118211/64995065-2558a480-d88f-11e9-9bbc-6c828b21cdd7.png) 175%, and 225% zoom seem to have the same artifact line pattern as 125% 200% zoom has no artifact. This looks similar to the artifact reported by @shanselman in https://github.com/microsoft/terminal/issues/455#issuecomment-518455051, but the issue I see is present independent of the fontFace setting (i see it both with fontFace set to Fira Code, and with fontFace setting removed thus falling back to the default fontFace). Note: I initially came across this while using multiple monitors, and the artifact presented itself when dragging between two monitors. It turns out that the Scale setting is on a per-monitor basis, so if anyone working on a fix has multiple monitors, they can test several scale settings in parallel, as dragging the window between monitors will dynamically apply the scaling to the window.
claunia added the Resolution-Duplicate label 2026-01-30 23:32:56 +00:00
claunia commented 2026-01-30 23:32:57 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 16, 2019):

This is actually still just /dup #455, even if the context is different. Thanks!

@DHowett-MSFT commented on GitHub (Sep 16, 2019): This is actually still just /dup #455, even if the context is different. Thanks!
claunia commented 2026-01-30 23:32:57 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 16, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Sep 16, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?