starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-09 02:26:45 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bug Report: if historySize >= 32728 a maximize doesn't redraw the terminal #3950

New Issue
Closed
opened 2026-01-30 23:34:02 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:34:02 +00:00
Owner
Copy Link

Originally created by @mcornella on GitHub (Sep 19, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: 10.0.18980.1
Windows Terminal version (if applicable): 0.4.2382.0

Any other software?

Steps to reproduce

  1. Set historySize of a profile to 32728 or bigger.
  2. Open a tab for that profile.
  3. Run commands so that there is a bunch of scroll space (running nano on Ubuntu is easier).
  4. Maximize the window.

Expected behavior

The terminal should redraw itself to occupy all the available space.

Actual behavior

The terminal keeps using the previously available space, not occupying the extra one. Some screenshots:

  1. After maximizing on Ubuntu:
    maximized on ubuntu

  2. After maximizing on cmd:
    maximized on cmd
    (Note the last dir output kept going but it was cut midway)

Other relevant information

A manual resize of the window does correctly trigger a redraw on Ubuntu. Not on cmd, which just keeps using the window space it had when the tab was opened.

Originally created by @mcornella on GitHub (Sep 19, 2019). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: 10.0.18980.1 Windows Terminal version (if applicable): 0.4.2382.0 Any other software? ``` # Steps to reproduce 1. Set historySize of a profile to 32728 or bigger. 2. Open a tab for that profile. 3. Run commands so that there is a bunch of scroll space (running `nano` on Ubuntu is easier). 4. Maximize the window. # Expected behavior The terminal should redraw itself to occupy all the available space. # Actual behavior The terminal keeps using the previously available space, not occupying the extra one. Some screenshots: 1. After maximizing on Ubuntu: ![maximized on ubuntu](https://user-images.githubusercontent.com/1441704/65267363-21d64f00-db15-11e9-9c03-63e1cc62c8df.png) 2. After maximizing on cmd: ![maximized on cmd](https://user-images.githubusercontent.com/1441704/65267505-6a8e0800-db15-11e9-8ba3-178a7aaa1813.png) _(Note the last `dir` output kept going but it was cut midway)_ # Other relevant information A manual resize of the window does correctly trigger a redraw on Ubuntu. Not on cmd, which just keeps using the window space it had when the tab was opened.
claunia commented 2026-01-30 23:34:03 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 19, 2019):

Well, that's a thinker.

@DHowett-MSFT commented on GitHub (Sep 19, 2019): Well, that's a thinker.
claunia commented 2026-01-30 23:34:03 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Sep 20, 2019):

Pretty much everything in the terminal implementation is a short, and while the initial history size is clamped, that's not enough to prevent an overflow when values are added. In this particular case, I believe the overflow is happening here:

4217bed9c8/src/cascadia/TerminalCore/Terminal.cpp (L167)

Clamping that result to SHORT_MAX seems to fix the issue, but I wouldn't want to bet on that being the only place that needs clamping. Conhost avoids the issue by limiting the scrollback to 9999, which seems like a safer approach.

@j4james commented on GitHub (Sep 20, 2019): Pretty much everything in the terminal implementation is a short, and while the initial history size is clamped, that's not enough to prevent an overflow when values are added. In this particular case, I believe the overflow is happening here: https://github.com/microsoft/terminal/blob/4217bed9c86fd0b804b44aebca2a9fdf556acc03/src/cascadia/TerminalCore/Terminal.cpp#L167 Clamping that result to SHORT_MAX seems to fix the issue, but I wouldn't want to bet on that being the only place that needs clamping. Conhost avoids the issue by limiting the scrollback to 9999, which seems like a safer approach.
claunia commented 2026-01-30 23:34:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 24, 2019):

Welp, that's certainly my fault there. That's definitely wrong there, good find.

I think we should definitely make sure to use this issue as a chance to go through and audit some of our math in the Terminal code and make sure we're safemathing/clamping it. I clearly didn't do that originally, and we should be.

IIRC technically only the propsheet limits you to 9999 rows for conhost. I believe if you edit the registry directly, you can sidestep that to get to SHORT_MAX.

@zadjii-msft commented on GitHub (Sep 24, 2019): Welp, that's certainly my fault there. That's definitely wrong there, good find. I think we should definitely make sure to use this issue as a chance to go through and audit some of our math in the Terminal code and make sure we're safemathing/clamping it. I clearly didn't do that originally, and we should be. IIRC technically only the propsheet limits you to 9999 rows for conhost. I believe if you edit the registry directly, you can sidestep that to get to SHORT_MAX.
claunia commented 2026-01-30 23:34:04 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Sep 25, 2019):

IIRC technically only the propsheet limits you to 9999 rows for conhost. I believe if you edit the registry directly, you can sidestep that to get to SHORT_MAX.

Yeah, you're right. But that means conhost likely has many issues like this too, and I suspect it's going to be a nightmare to audit.

Just look at AdjustCursorPosition as one example. That looks like it has several potential overflows, but I'm guessing the end result is still OK because of the way two's complement works (although technically it may be undefined behaviour). If you started clamping all of those calculations, though, it would probably cause more problems than it solved.

Personally I'd just clamp the initial buffer size to something like 30000, if that meant we could avoid having to deal with all those edge cases.

@j4james commented on GitHub (Sep 25, 2019): > IIRC technically only the propsheet limits you to 9999 rows for conhost. I believe if you edit the registry directly, you can sidestep that to get to SHORT_MAX. Yeah, you're right. But that means conhost likely has many issues like this too, and I suspect it's going to be a nightmare to audit. Just look at [`AdjustCursorPosition`](https://github.com/microsoft/terminal/blob/0c8a4df9636982fc92137c47b31877f2c7b5efdb/src/host/_stream.cpp#L43) as one example. That looks like it has several potential overflows, but I'm guessing the end result is still OK because of the way two's complement works (although technically it may be undefined behaviour). If you started clamping all of those calculations, though, it would probably cause more problems than it solved. Personally I'd just clamp the initial buffer size to something like 30000, if that meant we could avoid having to deal with all those edge cases.
claunia commented 2026-01-30 23:34:04 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 20, 2020):

:tada:This issue was addressed in #4964, which has now been successfully released as Windows Terminal Preview v0.10.781.0.🎉

Handy links:

@ghost commented on GitHub (Mar 20, 2020): :tada:This issue was addressed in #4964, which has now been successfully released as `Windows Terminal Preview v0.10.781.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.10.781.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?